Skip to content

fix fsdp2 checkpoint load #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstjohn merged 1 commit into from
Dec 12, 2025
Merged

fix fsdp2 checkpoint load #1375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bionemo-recipes/recipes/llama3_native_te/train_fsdp2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def main(args: DictConfig) -> float | None:
scheduler=scheduler,
ckpt_path=ckpt_path,
dist_config=dist_config,
dataloader=train_dataloader if args.dataset.use_stateful_dataloader else None,
dataloader=train_dataloader,
Copy link
Collaborator

@savitha-eng savitha-eng Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think esm2's train_fsdp2 also has this code - not sure if it needs to be fixed there too.

Copy link
Collaborator

@trvachov trvachov Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch if true

process_group=device_mesh.get_group("dp"),
)
logger.info(f"Checkpoint loaded, resuming from step {start_step}, epoch {epoch}")
Expand Down