fix fsdp2 checkpoint load #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter St. John <[email protected]>
pstjohn
requested review from
cspades,
dorotat-nv,
jomitchellnv,
jstjohn,
jwilber,
savitha-eng and
trvachov
as code owners
savitha-eng
approved these changes
Dec 12, 2025
savitha-eng
reviewed
Dec 12, 2025
| ckpt_path=ckpt_path, | ||
| dist_config=dist_config, | ||
| dataloader=train_dataloader if args.dataset.use_stateful_dataloader else None, | ||
| dataloader=train_dataloader, |
Collaborator
There was a problem hiding this comment.
i think esm2's train_fsdp2 also has this code - not sure if it needs to be fixed there too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass the dataloader even if we're not loading it from a checkpoint, since it gets passed through as none otherwise.