[develop] Update GSI and GSI-monitor hashes for EE2#4729
Open
CatherineThomas-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
Open
[develop] Update GSI and GSI-monitor hashes for EE2#4729CatherineThomas-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
CatherineThomas-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
Conversation
Contributor
|
@CatherineThomas-NOAA is this PR ready for review as well? |
Contributor
Author
|
@DavidHuber-NOAA - I had previously run CI tests with develop but there were several PRs merged since then, so I should rerun tests. I'll do that today. |
Contributor
Author
|
Tests on WCOSS2 and Gaea C6 pass (will post results separately). The |
CatherineThomas-NOAA
requested review from
DavidHuber-NOAA and
TravisElless-NOAA
as code owners
Contributor
Author
|
WCOSS2 -G -E -S -C Tests - All Pass |
Contributor
Author
|
Gaea C6 -G -E -S -C Tests - All Pass |
CatherineThomas-NOAA
requested review from
EdwardSafford-NOAA and
RussTreadon-NOAA
RussTreadon-NOAA
approved these changes
Apr 1, 2026
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
This PR updates sorc/gsi_enkf.fd to c2e7964. This hash removed unused variables from the GSI_MODE=Regional build. This build enables gsi.x to run in both global and regional modes.
One stated goal of this PR was to remove unused variables from the GSI. Updating sorc/gsi_enf.fd to c2e7964 is a step in this direction.
Approve.
DavidHuber-NOAA
approved these changes
Apr 1, 2026
EdwardSafford-NOAA
approved these changes
Apr 1, 2026
Contributor
EdwardSafford-NOAA
left a comment
EdwardSafford-NOAA
left a comment
There was a problem hiding this comment.
Changes to GSI-monitor are as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to #4728
Updates the GSI hash to remove unused variables (NOAA-EMC/GSI#989) and the GSI-monitor to remove goto statements (NOAA-EMC/GSI-Monitor#206) and unused scripts (NOAA-EMC/GSI-Monitor#207).
Refs #4676
Refs #4718
Type of change
Change characteristics
How has this been tested?
generate_workflows -G -E -S -C on WCOSS2 and Gaea C6 - All tests passed, but with an older merge of develop ( 83543df), I will rerun tests
develop at 83543df was run and the low-res v17 and C96 atm3dvar tests had identical results to this PR
Checklist