[dev/gfs.v17] Bring in updated MOM6 logging feature#4688
Open
dpsarmie wants to merge 13 commits intoNOAA-EMC:dev/gfs.v17from
Open
[dev/gfs.v17] Bring in updated MOM6 logging feature#4688dpsarmie wants to merge 13 commits intoNOAA-EMC:dev/gfs.v17from
dpsarmie wants to merge 13 commits intoNOAA-EMC:dev/gfs.v17from
Conversation
Contributor
Author
|
This will remain a draft until these changes are tested in GW and with GDASApp (due to changes in the MOM6 CMake file). |
Updates for CI to run
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
save the mom6 log files
Contributor
|
Before I run the CI tests on both Gaea and WCOSS2 - want to quickly check with @TravisElless-NOAA and @DavidHuber-NOAA if there are objections to the log names being, for example: |
Contributor
|
@JessicaMeixner-NOAA Yes, I think I'm good with this naming convention. |
Contributor
|
Ditto. Naming convention seems fine to me. |
Contributor
|
@dpsarmie - I think you can take this out of draft mode and I'll start the final round of CI tests. The CI check here that is failing is not related to the PR. |
Contributor
Author
|
Last commit to the fork brought in changes that had been staged here: #4648 I'll update the production/GFS.v17 UFSWM hash now. |
dpsarmie
requested review from
DavidHuber-NOAA and
TravisElless-NOAA
as code owners
Contributor
|
Gaea C6: WCOSS2: |
DavidHuber-NOAA
approved these changes
Apr 2, 2026
DavidHuber-NOAA
requested review from
CatherineThomas-NOAA,
RuiyuSun and
lgannoaa
Contributor
|
@lgannoaa this should add the log files needed for marine (ice and ocean) ecFlow triggers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will bring in MOM6 logging changes that are in the UFSWM develop branch to the GFSv17 branch in Global Workflow.
This PR will change the MOM6 output filenames by adding a
_00string to the name. This was a feature that was originally needed by the SFS project and now requested by GFS.This update is related to #4249 , which is the original request from SFS.
Refs #4717
Type of change
Change characteristics
How has this been tested?
These changes were tested just using the UFSWM regression tests. The WM itself passed testing, however this will still need to be tested in the GW.
Checklist