Fix unload/refresh virtual devices deadlock #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SiMet
commented
Nov 3, 2025
SiMet
commented
- Three unit tests created
- Created new method runJobOnExecutorAndWait in ControllerImpl to run job on executor and wait for compleation using marker job
- replace flush in deregisterVirtualControlledEntity and refreshEntity with runJobOnExecutorAndWait
SiMet
force-pushed
the
fix/unload-virtual-devices-deadlock
branch
from
c27d1c7 to
d3cbd31
Compare
christophe-calmejane
requested changes
Nov 3, 2025
|
|
||
| } | ||
|
|
||
| TEST(ControllerEntity, PushJobToExecutorWhileUnloadVirtualEntities) |
Collaborator
There was a problem hiding this comment.
same comments
SiMet
force-pushed
the
fix/unload-virtual-devices-deadlock
branch
from
d3cbd31 to
c7214c4
Compare
christophe-calmejane
requested changes
Nov 3, 2025
christophe-calmejane
requested changes
Nov 3, 2025
|
|
||
| private: | ||
| la::avdecc::ExecutorManager::ExecutorWrapper* _executor; | ||
| la::avdecc::ExecutorManager::ExecutorWrapper* _executor = nullptr; |
Collaborator
There was a problem hiding this comment.
Always use brace initialization (see CODING_STYLE_GUIDELINES)
| public: | ||
| JobPusherObserver(la::avdecc::ExecutorManager::ExecutorWrapper* executor) | ||
| : _executor(executor) | ||
| : la::avdecc::controller::Controller::DefaultedObserver() |
| JobPusherObserver(la::avdecc::ExecutorManager::ExecutorWrapper* executor) | ||
| : _executor(executor) | ||
| : la::avdecc::controller::Controller::DefaultedObserver() | ||
| , _executor(executor) |
Collaborator
There was a problem hiding this comment.
Use brace initialization
SiMet
force-pushed
the
fix/unload-virtual-devices-deadlock
branch
2 times, most recently
from
fd8ee12 to
c089aaa
Compare
christophe-calmejane
requested changes
Nov 4, 2025
| public: | ||
| JobPusherObserver(la::avdecc::ExecutorManager::ExecutorWrapper* executor) | ||
| : _executor(executor) | ||
| : _executor({ executor }) |
Collaborator
There was a problem hiding this comment.
I meant "only" brace initialization, like for class members :)
| [this]() | ||
| []() | ||
| { | ||
|
|
Collaborator
There was a problem hiding this comment.
This new line just appeared. Good thing anyway, please add a very small comment:
// Empty, just to force a job in the queue
And do the same for the other empty job. Thanks
SiMet
force-pushed
the
fix/unload-virtual-devices-deadlock
branch
from
c089aaa to
ce305d7
Compare
SiMet
force-pushed
the
fix/unload-virtual-devices-deadlock
branch
from
ce305d7 to
6227e9c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.