Fixes after code review

Author: SiMet

src/controller/avdeccControllerImpl.cpp

@@ -7053,7 +7053,7 @@ void ControllerImpl::runJobOnExecutorAndWait(la::avdecc::ExecutorManager& execut
 	{
 		// Ready to advertise using the network executor
 		executor.pushJob(exName,
-			[this, job]()
+			[this, job = std::move(job)]()
 			{
 				auto const lg = std::lock_guard{ *_controller }; // Lock the Controller itself (thus, lock it's ProtocolInterface), since we are on the Networking Thread
 				job();

src/controller/avdeccControllerImpl.hpp

@@ -807,7 +807,7 @@ class ControllerImpl final : public Controller, private entity::controller::Dele
 		return ControlledEntityImplGuard{ std::move(entity), locked };
 	}
 
-	void runJobOnExecutorAndWait(la::avdecc::ExecutorManager& executor, const std::string& exName, Executor::Job&& job) const noexcept;
+	void runJobOnExecutorAndWait(la::avdecc::ExecutorManager& executor, std::string const& exName, Executor::Job&& job) const noexcept;
 
 	/* ************************************************************ */
 	/* Private members                                              */

tests/src/controller/avdeccControlledEntity_tests.cpp

@@ -599,27 +599,29 @@ class JobPusherObserver : public la::avdecc::controller::Controller::DefaultedOb
 {
 public:
 	JobPusherObserver(la::avdecc::ExecutorManager::ExecutorWrapper* executor)
-		: _executor(executor)
+		: _executor{ executor }
 	{
 	}
 	virtual void onEntityOnline(la::avdecc::controller::Controller const* const /* controller */, la::avdecc::controller::ControlledEntity const* const /* entity*/) noexcept override
 	{
 		_executor->pushJob(
-			[this]()
+			[]()
 			{
+				// Empty, just to force a job in the queue
 			});
 	}
 
 	virtual void onEntityOffline(la::avdecc::controller::Controller const* const /* controller */, la::avdecc::controller::ControlledEntity const* const /* entity */) noexcept override
 	{
 		_executor->pushJob(
-			[this]()
+			[]()
 			{
+				// Empty, just to force a job in the queue
 			});
 	}
 
 private:
-	la::avdecc::ExecutorManager::ExecutorWrapper* _executor;
+	la::avdecc::ExecutorManager::ExecutorWrapper* const _executor{ nullptr };
 };
 } // namespace
 
@@ -633,7 +635,7 @@ TEST(ControllerEntity, PushJobToExecutorWhileLoadVirtualEntities)
 
 	// Verify if load does not dead lock
 	auto const future = std::async(std::launch::async,
-		[this, &controller, flags]()
+		[&controller, flags]()
 		{
 			auto const [error, message] = controller->loadVirtualEntityFromJson("data/SimpleEntity.json", flags);
 			EXPECT_EQ(la::avdecc::jsonSerializer::DeserializationError::NoError, error);
@@ -657,7 +659,7 @@ TEST(ControllerEntity, PushJobToExecutorWhileUnloadVirtualEntities)
 
 	// Verify if unload does not dead lock
 	auto const future = std::async(std::launch::async,
-		[this, &controller, flags]()
+		[&controller]()
 		{
 			controller->unloadVirtualEntity(la::avdecc::UniqueIdentifier{ 0x001B92FFFF000001 });
 		});
@@ -679,7 +681,7 @@ TEST(ControllerEntity, PushJobToExecutorWhileRefreshVirtualEntities)
 
 	// Verify if refresh does not dead lock
 	auto const future = std::async(std::launch::async,
-		[this, &controller, flags]()
+		[&controller]()
 		{
 			controller->refreshEntity(la::avdecc::UniqueIdentifier{ 0x001B92FFFF000001 });
 		});