Skip to content

fix(vars): remove request_time from default indexed variables #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix(vars): remove request_time from default indexed variables #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ concurrency:
jobs:
tests:
name: Lint
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04

steps:
- name: Checkout source code
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ index *commonly used variables* as follows:
- `$remote_port`
- `$request_length`
- `$request_method`
- `$request_time`
- `$request_uri`
- `$scheme`
- `$server_addr`
Expand Down
1 change: 0 additions & 1 deletion src/ngx_http_lua_kong_var_index.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ static ngx_str_t default_vars[] = {
/* ngx_string("request"), */
ngx_string("request_length"),
ngx_string("request_method"),
ngx_string("request_time"),
ngx_string("request_uri"),
ngx_string("scheme"),
ngx_string("server_addr"),
Expand Down
6 changes: 2 additions & 4 deletions t/006-default_indexed-var.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use Test::Nginx::Socket::Lua;

repeat_each(2);

plan tests => repeat_each() * (blocks() * 8) + 14;
plan tests => repeat_each() * (blocks() * 8) + 12;

#no_diff();
#no_long_string();
Expand Down Expand Up @@ -205,7 +205,6 @@ get variable value '666' by index
ngx.say(ngx.var.request_method, " ",
ngx.var.request_length, " ",
ngx.var.request_uri, " ",
ngx.var.request_time, " ",
ngx.var.server_addr, " ",
ngx.var.server_port
)
Expand All @@ -214,12 +213,11 @@ get variable value '666' by index
--- request
GET /test
--- response_body
GET 58 /test 0.000 127.0.0.1 1984
GET 58 /test 127.0.0.1 1984
--- error_log
get variable value 'GET' by index
get variable value '58' by index
get variable value '/test' by index
get variable value '0.000' by index
get variable value '127.0.0.1' by index
get variable value '1984' by index
--- no_error_log
Expand Down