fix(vars): remove request_time from default indexed variables #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruceo
force-pushed
the
fix/request_time_indexing
branch
from
284c343 to
1f9550b
Compare
The request_time variable was previously indexed by default in the NGINX module. However, this behavior is problematic because request_time is a dynamic value that changes over the request lifecycle. Indexing it causes the first access to cache its value, leading to incorrect results for subsequent accesses. This issue is particularly impactful in Active Tracing, where request_time is used during the log phase. The cached value can result in inaccurate tracing data. This is because the first access to this variable will cache it and subsequent accesses will use the cached value. This commit removes request_time from the list of default indexed variables to ensure its value is always retrieved dynamically. Corresponding test cases have been updated to reflect this change. Fix KAG-6868
gruceo
force-pushed
the
fix/request_time_indexing
branch
from
1f9550b to
ccf33db
Compare
chronolaw
approved these changes
Apr 26, 2025
samugi
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request_time variable was previously indexed by default in the NGINX module. However, this behavior is problematic because request_time is a dynamic value that changes over the request lifecycle. Indexing it causes the first access to cache its value, leading to incorrect results for subsequent accesses.
This issue is particularly impactful in Active Tracing, where request_time is used during the log phase. The cached value can result in inaccurate tracing data. This is because the first access to this variable will cache it and subsequent accesses will use the cached value.
This commit removes request_time from the list of default indexed variables to ensure its value is always retrieved dynamically. Corresponding test cases have been updated to reflect this change.
Fix KAG-6868