[JEWEL-1188] Caret not moving when the popup is visible #3352
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where clicking in an editable combo box text field while a popup is visible would dismiss the popup but fail to move the caret to the clicked position. Only happens with Custom Popup Renderer enabled.
The
AWTEventListenerwas consuming all mouse press events that triggered popup dismissal, including clicks on the owner component (editable combo box). When the event was consumed, it never reached the text field component, preventing caret repositioning.Solution
Removed the
event.consume()in theMouseEventbranch and leave the consume to happen in the compose layer, as it's done for theWindowEventlogic.Release notes
Bug fixes
Note
Fixes lost click handling when dismissing JDialog popups, ensuring clicks propagate to owner components for caret movement.
JDialogRenderer.kt, removeevent.consume()from theAWTEventListenerMouseEvent path that triggersonDismissRequestWindowEvent; compose layer now handles consumptionWritten by Cursor Bugbot for commit f7875bd. This will update automatically on new commits. Configure here.