Fix click outside and scrim drawing for WINDOW layers#1189
Merged
MatkovIvan merged 1 commit intojb-mainfrom Mar 13, 2024
Merged
Fix click outside and scrim drawing for WINDOW layers#1189MatkovIvan merged 1 commit intojb-mainfrom
WINDOW layers#1189MatkovIvan merged 1 commit intojb-mainfrom
Conversation
MatkovIvan
force-pushed
the
ivan.matkov/fix-window-layer-2
branch
from
df67f3c to
e8854e9
Compare
igordmn
requested changes
Mar 13, 2024
| private inner class DetectEventOutsideLayer : AwtEventFilter { | ||
| override fun shouldSendMouseEvent(event: MouseEvent): Boolean { | ||
| layersAbove.toList().fastForEachReversed { | ||
| it.onMouseEventOutside(event) |
Collaborator
There was a problem hiding this comment.
Better to call it somewhere else, not inside shouldSendMouseEvent, that by its name shouldn't generate side effects.
Or rename AwtEventFilter to AwtEventHandler, shouldSendMouseEvent to handleMouseEvent
Author
There was a problem hiding this comment.
Yep, thought about it, but it caused more unrelated changes
Author
There was a problem hiding this comment.
Let's do it separately, this PR is already big enough
igordmn
approved these changes
Mar 13, 2024
MatkovIvan
added a commit
that referenced
this pull request
Mar 13, 2024
## Proposed Changes - Apply suggested refactoring: replace `AwtEventFilter` to `AwtEventListener` ## Testing Test: N/A ## Issues Fixed Fixes #1189 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Set
compose.layers.type = WINDOWand try to usePopup/Dialogwindow_layers.mp4
Issues Fixed
Fixes #1187 (comment)