Filter events if there are focusable WINDOW layers#1187
Merged
MatkovIvan merged 2 commits intojb-mainfrom Mar 12, 2024
Merged
Conversation
igordmn
reviewed
Mar 12, 2024
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
Show resolved
Hide resolved
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
Show resolved
Hide resolved
igordmn
approved these changes
Mar 12, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/AwtEventFilter.desktop.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
added a commit
that referenced
this pull request
Mar 13, 2024
## Proposed Changes - Detect mouse input on previous layers to trigger "outside" events instead of generating it on focus lost - Draw scrim (with right blend mode) on all previous layers instead of just main content ## Testing Test: Set `compose.layers.type = WINDOW` and try to use `Popup`/`Dialog` https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/994717e5-401b-4ff0-9c31-b18d829e7da7 ## Issues Fixed Fixes #1187 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
WINDOWlayersTesting
Test: open focusable
WINDOWlayer withoutdismissOnClickOutside, try to click on the main content