-
Notifications
You must be signed in to change notification settings - Fork 32
Fix regression in spirv generator #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code around is hard to read. Need refactoring. In separate PR? |
Is it possible to make test for it? |
@@ -105,7 +105,7 @@ def generate(self, ipath, opath, llvm_spirv_args): | |||
llvm_spirv_call_args = ["llvm-spirv"] | |||
if llvm_spirv_args is not None: | |||
llvm_spirv_call_args += llvm_spirv_args | |||
llvm_spirv_call_args += ["-o", opath, ipath + ".bc"] | |||
llvm_spirv_call_args += [*llvm_spirv_flags, "-o", opath, ipath + ".bc"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted this change and test_function_with_debuginfo
PASSED. Why it could be?
Could you check it too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because (as I said earlier) this flag only fixes error in spirv-val mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spirv-val mode
Could you enable this mode in test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can, but checking spirv (spirv-val mode) is blocked by a set of problems. This flag fixes only one problem connected to appropriate Debug name in spirv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test does not test changes.
Yes. It tests calling function with debug in general. Currently it is hardly possible to write a test on checking failing in spirv-val mode because there are lots of other problems. |
@akharche what is the status now? |
Flag for debug was removed in previous prs