Skip to content

Remove kernel wrapper function #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

diptorupd
Copy link
Contributor

WIP changes to target.py to remove the wrapper function needed for every kernel.

@diptorupd diptorupd marked this pull request as draft May 19, 2021 05:25
@PokhodenkoSA PokhodenkoSA mentioned this pull request Jun 1, 2021
36 tasks
@diptorupd diptorupd force-pushed the fix/remove_kernel_wrapper branch 3 times, most recently from 61e878d to e1da898 Compare June 3, 2021 04:14
@diptorupd diptorupd force-pushed the fix/remove_kernel_wrapper branch 3 times, most recently from 5676ff7 to 7c634ef Compare June 7, 2021 03:08
@diptorupd
Copy link
Contributor Author

@PokhodenkoSA @akharche There are still 19 tests that are failing that I need to fix and then polish up the patch. I will get to it tomorrow my day. You can try it out. I expect basic use cases to work.

@PokhodenkoSA
Copy link
Contributor

PokhodenkoSA commented Jun 7, 2021

#412 merged. Please, resolve conflict and merge this PR with main. I think conflict is with #291 from @reazulhoque.

@akharche
Copy link
Contributor

akharche commented Jun 7, 2021

@diptorupd I tested it on nuc05 with neo driver version: https://github.com/intel/compute-runtime/releases/tag/21.22.19967 . And got core dump:

Abort was called at 211 line in file:
../neo/shared/source/kernel/kernel_arg_descriptor.h
Aborted (core dumped)

@diptorupd
Copy link
Contributor Author

@diptorupd I tested it on nuc05 with neo driver version: https://github.com/intel/compute-runtime/releases/tag/21.22.19967 . And got core dump:

@akharche what example were you running on nuc05? It will help me debug if you give me the reproducer.

@akharche
Copy link
Contributor

akharche commented Jun 7, 2021

@diptorupd I tested it on nuc05 with neo driver version: https://github.com/intel/compute-runtime/releases/tag/21.22.19967 . And got core dump:

@akharche what example were you running on nuc05? It will help me debug if you give me the reproducer.

Could you please try this reproducer? https://gist.github.com/akharche/2acf121caf2f58a7dd6f1d5074cbc51a

@diptorupd diptorupd force-pushed the fix/remove_kernel_wrapper branch from 7c634ef to 9e8407b Compare June 7, 2021 19:24
@diptorupd
Copy link
Contributor Author

closing the PR as we implemented an alternative workaround in #432

@diptorupd diptorupd closed this Jun 15, 2021
@diptorupd diptorupd deleted the fix/remove_kernel_wrapper branch November 13, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing kernel wrapper function
3 participants