-
Notifications
You must be signed in to change notification settings - Fork 32
Remove kernel wrapper function #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61e878d
to
e1da898
Compare
5676ff7
to
7c634ef
Compare
@PokhodenkoSA @akharche There are still 19 tests that are failing that I need to fix and then polish up the patch. I will get to it tomorrow my day. You can try it out. I expect basic use cases to work. |
#412 merged. Please, resolve conflict and merge this PR with main. I think conflict is with #291 from @reazulhoque. |
@diptorupd I tested it on nuc05 with neo driver version: https://github.com/intel/compute-runtime/releases/tag/21.22.19967 . And got core dump:
|
@akharche what example were you running on nuc05? It will help me debug if you give me the reproducer. |
Could you please try this reproducer? https://gist.github.com/akharche/2acf121caf2f58a7dd6f1d5074cbc51a |
7c634ef
to
9e8407b
Compare
closing the PR as we implemented an alternative workaround in #432 |
WIP changes to
target.py
to remove the wrapper function needed for every kernel.