Feature/mobile quick actions #604
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2022
nilmerg
requested changes
Jul 28, 2022
Comment on lines
+76
to
+77
| &:before { | ||
| right: 1.125em; | ||
| } |
There was a problem hiding this comment.
It’s to position the flyout's caret correctly. I made that clear with a comment.
There was a problem hiding this comment.
- Clicking on check now or remove ack nothing happens
It’s been fixed in Icinga/icingaweb2/feature/redesigned-mobile-menu
Please use the *Html methods if possible
✅
public/css/widget/quick-actions.less
Outdated
| background: @icinga-blue; | ||
| .appearance(none); | ||
| border: none; | ||
| color: @body-bg-color; |
flourish86
force-pushed
the
feature/mobile-quick-actions
branch
2 times, most recently
from
872e93c to
244d4c1
Compare
refs Icinga/icingaweb2/#4649
refs Icinga/icingaweb2/#4649
refs Icinga/icingaweb2/#4649
flourish86
force-pushed
the
feature/mobile-quick-actions
branch
from
244d4c1 to
cf44a98
Compare
…mns to be selected The `Sql::columns()` method doesn't override existing columns when calling this directly, because at this point the ipl/orm query has already collected all selectable columns, which are not required for this use case. A later call to the `columns()` method using the select base doesn't prevent all the columns registered by the query from being selected.
This ensures that all perfdata which can't be visualized are rendered exactly in the same order they are stored in the database after all vizualizable perfData are rendered.
For compatibility reasons all table rows should have borders at the start and at the end.
Since all the inconsistent column/redis key names have been renamed, we don't have to cache redis keys separately anymore. This PR applies all the `Service/Host` volatile state results directly to the respective state model.
Our tooling for icinga.com/docs fails to parse this link properly.
PHP performs loose comparison, so `0 == 'y'` is true. yay.
…@icinga.com>" and not sometimes as "Alexander Aleksandrovič Klimov <[email protected]>" to deduplicate myself in AUTHORS.
When icinga redis is down, icingadb also shut down after a few minutes. In this case, the real cause of icingadb being down is that redis is down. So we should check icinga redis status first.
The `isHasOne` check was made as the ipl-orm couldn't have known about specific relations. The relation collection is now part of this module so it can decide based on the name whether to collect one or not. fixes #534
…` class Since the vertical scrolling must disabled upon clip, only `overflow-x` property is set to `auto`. Similar to `performance-data-table` class in monitoring module. This fix disables the vertical scrolling in the `performance-data-table` when it overflows.
If the expiration time is set for a comment, we need to show the expire time. Use `ipl\Web\Widget\TimeUntil::class` for formatting and creating expiration time stamp. If the expiration time is not set show creation time. In this case use `ipl\Web\Widget\TimeAgo::class` for formatting and creating creation time stamp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Icinga/icingaweb2/#4750