Avoid duplicate column suggestions in search bar #556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
fix/avoid-duplicate-column-suggestion
branch
from
81f069d to
168bcc8
Compare
raviks789
force-pushed
the
fix/avoid-duplicate-column-suggestion
branch
from
168bcc8 to
e38a591
Compare
raviks789
changed the title
raviks789
force-pushed
the
fix/avoid-duplicate-column-suggestion
branch
2 times, most recently
from
110f51e to
d24ce21
Compare
raviks789
changed the title
nilmerg
requested changes
Jun 27, 2022
There was a problem hiding this comment.
A key feature of this procedure is to only produce as much results as necessary. This change produces all columns of all relations at once, making it more inefficient.
Please think of a different solution, maybe along the lines of filtering out duplicate relation targets in the sub-procedures.
`ObjectSuggestions::collectFilterColumns()` returns duplicate column names due to the sub-relations of the joined models. Hence, `ObjectSuggestions::fetchColumnSuggestions()` returns duplicate suggestions for column names for the search bar. This fix solves this issue by resolving the redefinition of the method parameter `$model` in `ObjectSuggestions::collectFilterColumns()` and not registering the duplicate models in `ObjectSuggestions::collectRelations()`.
raviks789
force-pushed
the
fix/avoid-duplicate-column-suggestion
branch
from
d24ce21 to
335c08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectSuggestions::collectFilterColumns()returns duplicate column names due to the sub-relations of the joined models. Hence,ObjectSuggestions::fetchColumnSuggestions()returns duplicate suggestions for column names for the search bar. This fix solves this issue by resolving the redefinition of the method parameter$modelinObjectSuggestions::collectFilterColumns()and not registering the duplicate models inObjectSuggestions::collectRelations().fix #534