Avoid duplicate column suggestion in Search bar.

raviks789 · raviks789 · commit 81f069de8d35 · 2022-06-21T16:27:21.000+02:00
diff --git a/library/Icingadb/Web/Control/SearchBar/ObjectSuggestions.php b/library/Icingadb/Web/Control/SearchBar/ObjectSuggestions.php
@@ -182,7 +182,8 @@ protected function fetchColumnSuggestions($searchTerm)
         $query = $model::on($this->getDb());
 
         // Ordinary columns first
-        foreach (self::collectFilterColumns($model, $query->getResolver()) as $columnName => $columnMeta) {
+        $ordinaryColumns = iterator_to_array(self::collectFilterColumns($model, $query->getResolver()));
+        foreach (array_unique($ordinaryColumns) as $columnName => $columnMeta) {
             yield $columnName => $columnMeta;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,8 @@ protected function fetchColumnSuggestions($searchTerm)`
`182`	`182`	`$query = $model::on($this->getDb());`
`183`	`183`
`184`	`184`	`// Ordinary columns first`
`185`		`- foreach (self::collectFilterColumns($model, $query->getResolver()) as $columnName => $columnMeta) {`
	`185`	`+ $ordinaryColumns = iterator_to_array(self::collectFilterColumns($model, $query->getResolver()));`
	`186`	`+ foreach (array_unique($ordinaryColumns) as $columnName => $columnMeta) {`
`186`	`187`	`yield $columnName => $columnMeta;`
`187`	`188`	`}`
`188`	`189`