fix: filegroup circular deps

[birunts]

Previously generated filegroup targets can contain dependency cycle.

The case here is that defined filegroup of a package should not have deps of other packages but rather to its :data package.

This change removes potential dependency cycles and makes references to package's :data.

Resolves #163 & Closes #163.

[thesayyn]

I don't think this solves the problem. By not depending on the :data target only, you are excluding the transitive dependencies, that's why you don't see the problem anymore but this basically breaks everything if i am not mistaken.

[birunts]

Agree. But currently package filegroups are defined wrong and you cannot even use it (bazelisk build @bookworm//libgcc-s1:libgcc-s1). If package should be done this way to contain transitive dependencies, definitely it cannot be filegroup but rather custom rule who will be able to handle that somehow.

From another side gathering all needed _PACKAGES is pointless as if packages should handle transitive dependencies then this list should contain only those explicitly specified in bookworm.yaml file where transitive deps will be resolved.
So even better that real filegroup package (e.g. @bookworm//libgcc-s1/amd64:amd64) do not contain deps but only its :data and

Indeed current change is not a fix but rather a quick workaround. What I see now, the real package (e.g. @bookworm//libgcc-s1/amd64:amd64) is a custom rule who contains package :data only and returns a provider with its (Depends,Recommends,Suggests,Breaks) dependencies similarly as dep packages do.
Then main package container is also a custom rule who can use that provider(s) and produce a target with full list of packages :data to be installed.

At least this is mine understanding of current state 🤷‍♂️