Cycle error when using all-in-one target

[purkhusid]

Bazel complains about a cycle in the dependency graph when I try to use the all-in-one target and provide it to a oci_image

I've created a repro here: https://github.com/purkhusid/distroless_cycle_repro

You can reproduce the cycle error by running bazel build @bookworm//:bookworm

[birunts]

Indeed previous fix #155 did not resolve the topic fully (haven't hit such deps 😆). Having a quick look again at it makes me feel of broken desing of the generated filegroups who should not depend on the other package definitions but rather on its :data only.

The #164 fix corrects filegroups definitions. But not sure what was the design for generated filegroups and the way of its usage.
@thesayyn are there other usages expected for those filegroups?

[thesayyn]

filegroup is not the problem here. we need to find cycles in the dependency graph during resolution and flatten edges that have cycles.

[havasd]

could you please let me know if you have plans on moving forward with the fix for this change? It is a very common problem which we hit pretty easily.