This repository was archived by the owner on Jun 3, 2025. It is now read-only.
fix checkPushPermissions by --insecure#683
Closed
cn-sunletian wants to merge 19 commits intoGoogleContainerTools:masterfrom
Closed
fix checkPushPermissions by --insecure#683cn-sunletian wants to merge 19 commits intoGoogleContainerTools:masterfrom
cn-sunletian wants to merge 19 commits intoGoogleContainerTools:masterfrom
Conversation
Contributor
|
Have a look at #663. |
cn-sunletian
changed the title
cn-sunletian
changed the title
yehiyam
added a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 1, 2019
needs PR GoogleContainerTools/kaniko#683 to be merged
yehiyam
added a commit
to kube-HPC/kaniko
that referenced
this pull request
Jul 1, 2019
until GoogleContainerTools/kaniko#683 is merged
nassiharel
pushed a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 1, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged
hkube-ci
pushed a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 1, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged .... bump version [skip ci]
hkube-ci
pushed a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 1, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged .... bump version [skip ci]
Author
|
@kokoro-team plz check it |
|
@priyawadhwa @sharifelgamal With the current release 0.10 I get HTTPS issues, I created my own image from @cn-sunletian fork samyco/kaniko and it works. |
priyawadhwa
reviewed
Jul 24, 2019
Contributor
priyawadhwa
left a comment
priyawadhwa
left a comment
There was a problem hiding this comment.
This LGTM! I think you checked in the .idea directory by accident, could you remove those files? I also don't think the vendor directory needs to be updated in this case :)
This reverts commit 25995ea.
Author
|
@priyawadhwa Thank you for reminding me :) |
yehiyam
added a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 29, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify
hkube-ci
pushed a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 29, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
hkube-ci
pushed a commit
to kube-HPC/hkube
that referenced
this pull request
Jul 29, 2019
* support insecure registry needs PR GoogleContainerTools/kaniko#683 to be merged * save * supprt insecure and skip-verify .... bump version [skip ci]
Contributor
|
@cn-sunletian can you fix the lint errors? Looking forward to get this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our registry is harbor by http. When I push image, error occurred on function CheckPushPermissions.
Even add "--insecure" that doesn't work, but add "--insecure-pull" it can pull well.So i find "push.go" an error here. #737