This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add SkipVerify support to CheckPushPermissions.#663
Merged
sharifelgamal merged 1 commit intoGoogleContainerTools:masterfrom Jun 14, 2019
Merged
Add SkipVerify support to CheckPushPermissions.#663sharifelgamal merged 1 commit intoGoogleContainerTools:masterfrom
sharifelgamal merged 1 commit intoGoogleContainerTools:masterfrom
Conversation
Extract makeTransport, which allows using the current mechanism used for pushing. Fixes GoogleContainerTools#628.
dbolshak
approved these changes
May 17, 2019
dbolshak
left a comment
dbolshak
left a comment
There was a problem hiding this comment.
@abergmeier Thank you very much.
Looking forward for that change set!
|
I've pulled master and applied this patch, and can confirm that it works. |
Contributor
|
Thanks for the contribution! Sorry for the delay getting it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract makeTransport, which allows using the current mechanism used for
pushing.
Fixes #628.