Skip to content

Fixed market order bug using Order.Price #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Conversation

vslee
Copy link
Collaborator

@vslee vslee commented Aug 1, 2021

Continuation of #615 with requested changes.
Original PR comment by @raymens

This change was required to make Marketorders possible on CoinbasePro.
Not sure what the other echanges allow and or require so I've kept it simple by just assuming the price is given.

I suppose it's also possible to add checks and fail in a nicer way, what's your take on it?

@raymens
Copy link
Contributor

raymens commented Aug 2, 2021

Thanks a lot, I had it on my list of to-dos. But I appreciate this!

@vslee vslee requested a review from jjxtra August 2, 2021 16:13
@vslee vslee merged commit 39786cd into DigitalRuby:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants