Merge pull request #620 from vslee/master

Author: vslee

src/ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs

@@ -252,10 +252,12 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
 			switch (order.OrderType)
 			{
 				case OrderType.Limit:
-					data["price_int"] = converterToFive.FromDecimal(order.Price);
+					if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
+					data["price_int"] = converterToFive.FromDecimal(order.Price.Value);
 					break;
 				case OrderType.Market:
-					data["amount_funds_int"] = converterToFive.FromDecimal(roundedAmount * order.Price);
+					if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
+					data["amount_funds_int"] = converterToFive.FromDecimal(roundedAmount * order.Price.Value);
 					break;
 				default:
 					throw new NotSupportedException($"{order.OrderType} is not supported");

src/ExchangeSharp/API/Exchanges/BinanceGroup/BinanceGroupCommon.cs

@@ -443,7 +443,7 @@ public async Task OnGetHistoricalTradesAsync(Func<IEnumerable<ExchangeTrade>, bo
 			// TODO : Refactor into a common layer once more Exchanges implement this pattern
 			// https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#compressedaggregate-trades-list
 			if(limit > 1000) limit = 1000;	//Binance max = 1000
-			var maxRequestLimit = 1000; 
+			var maxRequestLimit = 1000;
 			var trades = new List<ExchangeTrade>();
 			var processedIds = new HashSet<long>();
 			marketSymbol = NormalizeMarketSymbol(marketSymbol);
@@ -548,6 +548,7 @@ protected override async Task<Dictionary<string, decimal>> OnGetAmountsAvailable
 
 		protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrderRequest order)
 		{
+			if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
 			Dictionary<string, object> payload = await GetNoncePayloadAsync();
 			payload["symbol"] = order.MarketSymbol;
 			payload["newClientOrderId"] = order.ClientOrderId;
@@ -559,7 +560,7 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
 
 			// Binance has strict rules on which prices and quantities are allowed. They have to match the rules defined in the market definition.
 			decimal outputQuantity = await ClampOrderQuantity(order.MarketSymbol, order.Amount);
-			decimal outputPrice = await ClampOrderPrice(order.MarketSymbol, order.Price);
+			decimal outputPrice = await ClampOrderPrice(order.MarketSymbol, order.Price.Value);
 
 			// Binance does not accept quantities with more than 20 decimal places.
 			payload["quantity"] = Math.Round(outputQuantity, 20);

src/ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs

@@ -481,7 +481,8 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
 
 			if (order.OrderType != OrderType.Market)
 			{
-				payload["price"] = (await ClampOrderPrice(marketSymbol, order.Price)).ToStringInvariant();
+				if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
+				payload["price"] = (await ClampOrderPrice(marketSymbol, order.Price.Value)).ToStringInvariant();
 			}
 			else
 			{

src/ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs

@@ -202,7 +202,8 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
 
             if (order.OrderType != OrderType.Market)
             {
-                payload["price"] = order.Price.ToStringInvariant();
+				if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
+				payload["price"] = order.Price.ToStringInvariant();
             }
 
             payload["amount"] = order.RoundAmount().ToStringInvariant();
@@ -442,7 +443,7 @@ protected override async Task<IEnumerable<ExchangeOrderResult>> OnGetCompletedOr
             List<ExchangeOrderResult> orders2 = new List<ExchangeOrderResult>();
             foreach (var group in groupings)
             {
-                decimal spentQuoteCurrency = group.Sum(o => o.AveragePrice * o.AmountFilled);
+                decimal spentQuoteCurrency = group.Sum(o => o.AveragePrice.Value * o.AmountFilled);
                 ExchangeOrderResult order = group.First();
                 order.AmountFilled = group.Sum(o => o.AmountFilled);
                 order.AveragePrice = spentQuoteCurrency / order.AmountFilled;

src/ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI.cs

@@ -84,7 +84,7 @@ private ExchangeOrderResult ParseOrder(JToken token)
 			decimal amountFilled = token["fillQuantity"].ConvertInvariant<decimal>();
 			order.Amount = amount;
 			order.AmountFilled = amountFilled;
-			order.Price = token["limit"].ConvertInvariant<decimal>(order.AveragePrice);
+			order.Price = token["limit"].ConvertInvariant<decimal>(order.AveragePrice.Value);
 			order.Message = string.Empty;
 			order.OrderId = token["id"].ToStringInvariant();
 
@@ -378,7 +378,8 @@ protected override async Task<ExchangeOrderResult> OnPlaceOrderAsync(ExchangeOrd
 		{
 
 			decimal orderAmount = await ClampOrderQuantity(order.MarketSymbol, order.Amount);
-			decimal orderPrice = await ClampOrderPrice(order.MarketSymbol, order.Price);
+			if (order.Price == null) throw new ArgumentNullException(nameof(order.Price));
+			decimal orderPrice = await ClampOrderPrice(order.MarketSymbol, order.Price.Value);
 			string url = "/orders";
 			Dictionary<string, object> orderParams = await GetNoncePayloadAsync();
 			orderParams.Add("marketSymbol", order.MarketSymbol);
@@ -507,7 +508,7 @@ protected override async Task<ExchangeWithdrawalResponse> OnWithdrawAsync(Exchan
 		{
 			/*
 				"currencySymbol": "string",
-				"quantity": "number (double)",			
+				"quantity": "number (double)",
 				"cryptoAddress": "string",
 				"cryptoAddressTag": "string",
 				"clientWithdrawalId": "string (uuid)"