Skip to content

GetHistoricalTradesAsync/GetRecentTradesAsync - Multiple Exchanges #510

Closed
@GonzoKK

Description

@GonzoKK

Also refer #508

Many exchanges support specifying a limit for number of trades. Currently however - neither GetHistoricalTradesAsync/GetRecentTradesAsync accept int? limit = null as an argument.

As a result, in Sharp - limit is hard coded on many exchanges. Bitfinex is just one example...
image
Bitfinex however supports a limit of 10000 https://docs.bitfinex.com/reference#rest-public-trades

On my side:

  1. I've added int? limit as a parameter to GetHistoricalTradesAsync & GetRecentTradesAsync (this impacts many files)
  2. I added/fixed GetRecentTradesAsync on multiple exchanges (Binance, HitBTC, Bitfinex and numerous others)
    image
  3. For GetRecentTradesAsync , the sort order will be Descending (ie newest trades first)

Here's a link here to a zip file with updated source files...

ExchangeSharp_Code_Changes_2020_01_20.zip
http://k00.fr/gzceuhp4 | password: 907394

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions