-
Notifications
You must be signed in to change notification settings - Fork 312
Ensure client stat reporter is started when the agent is not available at bootstrap #9082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
reviewed
Jul 2, 2025
dd-trace-core/src/main/java/datadog/trace/common/metrics/ConflatingMetricsAggregator.java
Show resolved
Hide resolved
...race-core/src/test/groovy/datadog/trace/common/metrics/ConflatingMetricAggregatorTest.groovy
Outdated
Show resolved
Hide resolved
bric3
approved these changes
Jul 2, 2025
mcculls
approved these changes
Jul 2, 2025
…flatingMetricAggregatorTest.groovy Co-authored-by: Brice Dutheil <[email protected]>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (999.817 ms) : 0, 999817
Total [baseline] (10.599 s) : 0, 10599414
Agent [candidate] (997.587 ms) : 0, 997587
Total [candidate] (10.725 s) : 0, 10724783
section appsec
Agent [baseline] (1.177 s) : 0, 1177444
Total [baseline] (10.733 s) : 0, 10732896
Agent [candidate] (1.175 s) : 0, 1175462
Total [candidate] (10.775 s) : 0, 10775478
section iast
Agent [baseline] (1.13 s) : 0, 1130473
Total [baseline] (10.841 s) : 0, 10841476
Agent [candidate] (1.131 s) : 0, 1131472
Total [candidate] (10.864 s) : 0, 10864056
section profiling
Agent [baseline] (1.252 s) : 0, 1251718
Total [baseline] (11.042 s) : 0, 11042479
Agent [candidate] (1.246 s) : 0, 1246479
Total [candidate] (10.996 s) : 0, 10996014
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.76 ms) : 0, 690760
BytebuddyAgent [candidate] (688.602 ms) : 0, 688602
GlobalTracer [baseline] (242.999 ms) : 0, 242999
GlobalTracer [candidate] (242.796 ms) : 0, 242796
AppSec [baseline] (30.257 ms) : 0, 30257
AppSec [candidate] (30.446 ms) : 0, 30446
Debugger [baseline] (6.078 ms) : 0, 6078
Debugger [candidate] (6.075 ms) : 0, 6075
Remote Config [baseline] (683.229 µs) : 0, 683
Remote Config [candidate] (680.911 µs) : 0, 681
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.206 ms) : 0, 8206
section appsec
BytebuddyAgent [baseline] (712.503 ms) : 0, 712503
BytebuddyAgent [candidate] (711.21 ms) : 0, 711210
GlobalTracer [baseline] (236.301 ms) : 0, 236301
GlobalTracer [candidate] (235.693 ms) : 0, 235693
AppSec [baseline] (171.151 ms) : 0, 171151
AppSec [candidate] (171.207 ms) : 0, 171207
Debugger [baseline] (5.785 ms) : 0, 5785
Debugger [candidate] (5.79 ms) : 0, 5790
Remote Config [baseline] (617.517 µs) : 0, 618
Remote Config [candidate] (608.111 µs) : 0, 608
Telemetry [baseline] (8.065 ms) : 0, 8065
Telemetry [candidate] (8.116 ms) : 0, 8116
IAST [baseline] (22.146 ms) : 0, 22146
IAST [candidate] (22.092 ms) : 0, 22092
section iast
BytebuddyAgent [baseline] (806.923 ms) : 0, 806923
BytebuddyAgent [candidate] (808.111 ms) : 0, 808111
GlobalTracer [baseline] (233.27 ms) : 0, 233270
GlobalTracer [candidate] (233.123 ms) : 0, 233123
AppSec [baseline] (28.985 ms) : 0, 28985
AppSec [candidate] (27.415 ms) : 0, 27415
Debugger [baseline] (5.784 ms) : 0, 5784
Debugger [candidate] (5.841 ms) : 0, 5841
Remote Config [baseline] (579.44 µs) : 0, 579
Remote Config [candidate] (591.653 µs) : 0, 592
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.869 ms) : 0, 7869
IAST [baseline] (26.253 ms) : 0, 26253
IAST [candidate] (27.743 ms) : 0, 27743
section profiling
BytebuddyAgent [baseline] (682.363 ms) : 0, 682363
BytebuddyAgent [candidate] (678.668 ms) : 0, 678668
GlobalTracer [baseline] (363.105 ms) : 0, 363105
GlobalTracer [candidate] (362.077 ms) : 0, 362077
AppSec [baseline] (31.164 ms) : 0, 31164
AppSec [candidate] (33.194 ms) : 0, 33194
Debugger [baseline] (11.395 ms) : 0, 11395
Debugger [candidate] (9.246 ms) : 0, 9246
Remote Config [baseline] (663.04 µs) : 0, 663
Remote Config [candidate] (664.654 µs) : 0, 665
Telemetry [baseline] (10.252 ms) : 0, 10252
Telemetry [candidate] (10.244 ms) : 0, 10244
ProfilingAgent [baseline] (103.979 ms) : 0, 103979
ProfilingAgent [candidate] (103.751 ms) : 0, 103751
Profiling [baseline] (104.004 ms) : 0, 104004
Profiling [candidate] (103.775 ms) : 0, 103775
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (998.236 ms) : 0, 998236
Total [baseline] (8.602 s) : 0, 8601736
Agent [candidate] (1.002 s) : 0, 1002306
Total [candidate] (8.571 s) : 0, 8570698
section iast
Agent [baseline] (1.134 s) : 0, 1134239
Total [baseline] (9.291 s) : 0, 9290791
Agent [candidate] (1.139 s) : 0, 1139245
Total [candidate] (9.279 s) : 0, 9279216
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.252 ms) : 0, 689252
BytebuddyAgent [candidate] (692.778 ms) : 0, 692778
GlobalTracer [baseline] (242.77 ms) : 0, 242770
GlobalTracer [candidate] (243.099 ms) : 0, 243099
AppSec [baseline] (30.376 ms) : 0, 30376
AppSec [candidate] (30.468 ms) : 0, 30468
Debugger [baseline] (6.082 ms) : 0, 6082
Debugger [candidate] (6.081 ms) : 0, 6081
Remote Config [baseline] (688.443 µs) : 0, 688
Remote Config [candidate] (688.198 µs) : 0, 688
Telemetry [baseline] (8.268 ms) : 0, 8268
Telemetry [candidate] (8.284 ms) : 0, 8284
section iast
BytebuddyAgent [baseline] (809.676 ms) : 0, 809676
BytebuddyAgent [candidate] (813.741 ms) : 0, 813741
GlobalTracer [baseline] (233.48 ms) : 0, 233480
GlobalTracer [candidate] (234.65 ms) : 0, 234650
AppSec [baseline] (27.129 ms) : 0, 27129
AppSec [candidate] (26.926 ms) : 0, 26926
Debugger [baseline] (5.836 ms) : 0, 5836
Debugger [candidate] (5.849 ms) : 0, 5849
Remote Config [baseline] (591.937 µs) : 0, 592
Remote Config [candidate] (586.016 µs) : 0, 586
Telemetry [baseline] (8.034 ms) : 0, 8034
Telemetry [candidate] (7.996 ms) : 0, 7996
IAST [baseline] (28.755 ms) : 0, 28755
IAST [candidate] (28.621 ms) : 0, 28621
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (36.643 ms) : 36339, 36947
. : milestone, 36643,
appsec (47.707 ms) : 47286, 48129
. : milestone, 47707,
code_origins (45.564 ms) : 45170, 45958
. : milestone, 45564,
iast (45.653 ms) : 45253, 46053
. : milestone, 45653,
profiling (49.786 ms) : 49273, 50298
. : milestone, 49786,
tracing (44.973 ms) : 44586, 45360
. : milestone, 44973,
section candidate
no_agent (37.216 ms) : 36910, 37521
. : milestone, 37216,
appsec (44.716 ms) : 44331, 45101
. : milestone, 44716,
code_origins (45.602 ms) : 45202, 46001
. : milestone, 45602,
iast (45.321 ms) : 44936, 45707
. : milestone, 45321,
profiling (47.468 ms) : 47005, 47931
. : milestone, 47468,
tracing (43.423 ms) : 43066, 43780
. : milestone, 43423,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (4.382 ms) : 4333, 4431
. : milestone, 4382,
iast (9.336 ms) : 9186, 9485
. : milestone, 9336,
iast_FULL (13.387 ms) : 13124, 13649
. : milestone, 13387,
iast_GLOBAL (9.892 ms) : 9712, 10072
. : milestone, 9892,
profiling (8.729 ms) : 8587, 8871
. : milestone, 8729,
tracing (7.55 ms) : 7444, 7656
. : milestone, 7550,
section candidate
no_agent (4.362 ms) : 4313, 4412
. : milestone, 4362,
iast (9.128 ms) : 8974, 9282
. : milestone, 9128,
iast_FULL (13.524 ms) : 13263, 13786
. : milestone, 13524,
iast_GLOBAL (9.772 ms) : 9606, 9938
. : milestone, 9772,
profiling (8.685 ms) : 8543, 8827
. : milestone, 8685,
tracing (7.337 ms) : 7228, 7445
. : milestone, 7337,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
appsec (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
iast (18.455 s) : 18455000, 18455000
. : milestone, 18455000,
iast_GLOBAL (17.82 s) : 17820000, 17820000
. : milestone, 17820000,
profiling (15.245 s) : 15245000, 15245000
. : milestone, 15245000,
tracing (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
section candidate
no_agent (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.711 s) : 18711000, 18711000
. : milestone, 18711000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.716 s) : 15716000, 15716000
. : milestone, 15716000,
tracing (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ca32710e43, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.414 ms) : 2365, 2464
. : milestone, 2414,
iast (2.2 ms) : 2138, 2262
. : milestone, 2200,
iast_GLOBAL (2.25 ms) : 2188, 2313
. : milestone, 2250,
profiling (2.059 ms) : 2008, 2110
. : milestone, 2059,
tracing (2.014 ms) : 1965, 2062
. : milestone, 2014,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.406 ms) : 2357, 2455
. : milestone, 2406,
iast (2.205 ms) : 2143, 2267
. : milestone, 2205,
iast_GLOBAL (2.238 ms) : 2176, 2301
. : milestone, 2238,
profiling (2.063 ms) : 2011, 2114
. : milestone, 2063,
tracing (2.017 ms) : 1969, 2064
. : milestone, 2017,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 10, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#​304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#​306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#​9083](DataDog/dd-trace-java#9083) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#​9028](DataDog/dd-trace-java#9028) - [@​jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#​8984](DataDog/dd-trace-java#8984) - [@​smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#​8885](DataDog/dd-trace-java#8885) - [@​jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#​9022](DataDog/dd-trace-java#9022) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#​9015](DataDog/dd-trace-java#9015) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#​9014](DataDog/dd-trace-java#9014) - [@​jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#​9013](DataDog/dd-trace-java#9013) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#​9009](DataDog/dd-trace-java#9009) - [@​smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#​9001](DataDog/dd-trace-java#9001) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#​8995](DataDog/dd-trace-java#8995) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#​8980](DataDog/dd-trace-java#8980) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#​8938](DataDog/dd-trace-java#8938) - [@​sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#​8937](DataDog/dd-trace-java#8937) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#​9023](DataDog/dd-trace-java#9023) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#​8807](DataDog/dd-trace-java#8807) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#​9114](DataDog/dd-trace-java#9114) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#​9033](DataDog/dd-trace-java#9033) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#​8990](DataDog/dd-trace-java#8990) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#​8923](DataDog/dd-trace-java#8923) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#​8776](DataDog/dd-trace-java#8776) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#​9025](DataDog/dd-trace-java#9025) - [@​natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#​9115](DataDog/dd-trace-java#9115) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#​9111](DataDog/dd-trace-java#9111) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#​9047](DataDog/dd-trace-java#9047) - [@​jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#​9034](DataDog/dd-trace-java#9034) - [@​jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#​8959](DataDog/dd-trace-java#8959) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#​8940](DataDog/dd-trace-java#8940) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#​8781](DataDog/dd-trace-java#8781) - [@​gary-huang](https://github.com/gary-huang), [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#​9082](DataDog/dd-trace-java#9082) - [@​amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#​8394](DataDog/dd-trace-java#8394) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#​9071](DataDog/dd-trace-java#9071) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#​9119](DataDog/dd-trace-java#9119) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#​8988](DataDog/dd-trace-java#8988) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#​9110](DataDog/dd-trace-java#9110) - [@​PerfectSlayer](https://github.com/PerfectSlayer) [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#​9045](DataDog/dd-trace-java#9045) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#​8875](DataDog/dd-trace-java#8875) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#​9037](DataDog/dd-trace-java#9037) - [@​mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#​9032](DataDog/dd-trace-java#9032) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#​9097](DataDog/dd-trace-java#9097) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#​9067](DataDog/dd-trace-java#9067) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#​8781](DataDog/dd-trace-java#8781) - [@​gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#​9019](DataDog/dd-trace-java#9019) - [@​mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#​9001](DataDog/dd-trace-java#9001) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#​8952](DataDog/dd-trace-java#8952) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#​9030](DataDog/dd-trace-java#9030) - [@​bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#​9014](DataDog/dd-trace-java#9014) - [@​jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#​9016](DataDog/dd-trace-java#9016) - [@​amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#​8995](DataDog/dd-trace-java#8995) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#​9013](DataDog/dd-trace-java#9013) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#​8938](DataDog/dd-trace-java#8938) - [@​sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
If the tracer starts and the agent is not yet available the discovery fails. However, if the user enabled the client stats, the reporting thread will exit soon because the lack of agent discovery is considered as if the metrics are not supported.
However, if the agent is detected later, there is no chance for the metric reporter to send the client stats. On the other side, we notify the agent through the info endpoint that that tracer instance will compute the metric, hence the agent won't do it and at the end of the game nobody will calculate the stats, that's an issue.
This PR ensures that that reporter job is starting regardless the status of the discovery. Please note that the conflating aggregator is only started if the client stats are enabled otherwise a no-op version is used.
Also, even if that reporter is started, there are several checks when publishing or reporting that are checking if the feature is available, making this fix safe also in term of possible perf degradations.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMS-15707