Create metric: appsec.waf.config_errors #8394

sezen-datadog · 2025-02-14T15:38:26Z

What Does This Do

Creates metric appsec.waf.config_errors which keeps count of errors reported by the WAF on each rule addition

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56480

pr-commenter · 2025-02-14T16:17:20Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sezen.leblay/APPSEC-56480-config_errors
git_commit_date	1750857432	1750859728
git_commit_sha	`2f749a9`	8434d39cfc
release_version	1.51.0-SNAPSHOT~2f749a97c7	1.51.0-SNAPSHOT~d8434d39cfc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750860980	1750860980
ci_job_id	998007484	998007484
ci_pipeline_id	68731460	68731460
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-bziamzy-project-304-concurrent-1-l1kg2qkm 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-bziamzy-project-304-concurrent-1-l1kg2qkm 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (995.133 ms) : 0, 995133
Total [baseline] (8.57 s) : 0, 8569938
Agent [candidate] (1.004 s) : 0, 1004269
Total [candidate] (8.56 s) : 0, 8559580
section iast
Agent [baseline] (1.127 s) : 0, 1127290
Total [baseline] (9.233 s) : 0, 9232673
Agent [candidate] (1.129 s) : 0, 1128893
Total [candidate] (9.224 s) : 0, 9224275

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	995.133 ms	-
Agent	iast	1.127 s	132.157 ms (13.3%)
Total	tracing	8.57 s	-
Total	iast	9.233 s	662.735 ms (7.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.004 s	-
Agent	iast	1.129 s	124.624 ms (12.4%)
Total	tracing	8.56 s	-
Total	iast	9.224 s	664.695 ms (7.8%)

gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.005 ms) : 0, 687005
BytebuddyAgent [candidate] (693.574 ms) : 0, 693574
GlobalTracer [baseline] (242.261 ms) : 0, 242261
GlobalTracer [candidate] (244.023 ms) : 0, 244023
AppSec [baseline] (30.24 ms) : 0, 30240
AppSec [candidate] (30.624 ms) : 0, 30624
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.077 ms) : 0, 6077
Remote Config [baseline] (666.352 µs) : 0, 666
Remote Config [candidate] (675.479 µs) : 0, 675
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (8.274 ms) : 0, 8274
section iast
BytebuddyAgent [baseline] (805.318 ms) : 0, 805318
BytebuddyAgent [candidate] (806.383 ms) : 0, 806383
GlobalTracer [baseline] (232.099 ms) : 0, 232099
GlobalTracer [candidate] (232.014 ms) : 0, 232014
AppSec [baseline] (28.995 ms) : 0, 28995
AppSec [candidate] (30.018 ms) : 0, 30018
Debugger [baseline] (5.684 ms) : 0, 5684
Debugger [candidate] (5.757 ms) : 0, 5757
Remote Config [baseline] (569.78 µs) : 0, 570
Remote Config [candidate] (570.96 µs) : 0, 571
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.934 ms) : 0, 7934
IAST [baseline] (26.062 ms) : 0, 26062
IAST [candidate] (25.447 ms) : 0, 25447

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (992.651 ms) : 0, 992651
Total [baseline] (10.769 s) : 0, 10769390
Agent [candidate] (994.018 ms) : 0, 994018
Total [candidate] (10.694 s) : 0, 10694481
section appsec
Agent [baseline] (1.172 s) : 0, 1172179
Total [baseline] (10.708 s) : 0, 10708014
Agent [candidate] (1.17 s) : 0, 1170231
Total [candidate] (10.661 s) : 0, 10660711
section iast
Agent [baseline] (1.139 s) : 0, 1138677
Total [baseline] (10.829 s) : 0, 10828901
Agent [candidate] (1.132 s) : 0, 1132434
Total [candidate] (10.837 s) : 0, 10836954
section profiling
Agent [baseline] (1.242 s) : 0, 1242206
Total [baseline] (10.975 s) : 0, 10975174
Agent [candidate] (1.243 s) : 0, 1243143
Total [candidate] (10.944 s) : 0, 10943957

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	992.651 ms	-
Agent	appsec	1.172 s	179.528 ms (18.1%)
Agent	iast	1.139 s	146.025 ms (14.7%)
Agent	profiling	1.242 s	249.555 ms (25.1%)
Total	tracing	10.769 s	-
Total	appsec	10.708 s	-61.377 ms (-0.6%)
Total	iast	10.829 s	59.511 ms (0.6%)
Total	profiling	10.975 s	205.783 ms (1.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	994.018 ms	-
Agent	appsec	1.17 s	176.213 ms (17.7%)
Agent	iast	1.132 s	138.416 ms (13.9%)
Agent	profiling	1.243 s	249.125 ms (25.1%)
Total	tracing	10.694 s	-
Total	appsec	10.661 s	-33.769 ms (-0.3%)
Total	iast	10.837 s	142.473 ms (1.3%)
Total	profiling	10.944 s	249.476 ms (2.3%)

gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.168 ms) : 0, 685168
BytebuddyAgent [candidate] (686.233 ms) : 0, 686233
GlobalTracer [baseline] (241.557 ms) : 0, 241557
GlobalTracer [candidate] (241.875 ms) : 0, 241875
AppSec [baseline] (30.297 ms) : 0, 30297
AppSec [candidate] (30.141 ms) : 0, 30141
Debugger [baseline] (5.979 ms) : 0, 5979
Debugger [candidate] (6.01 ms) : 0, 6010
Remote Config [baseline] (658.99 µs) : 0, 659
Remote Config [candidate] (671.08 µs) : 0, 671
Telemetry [baseline] (8.188 ms) : 0, 8188
Telemetry [candidate] (8.214 ms) : 0, 8214
section appsec
BytebuddyAgent [baseline] (709.869 ms) : 0, 709869
BytebuddyAgent [candidate] (708.324 ms) : 0, 708324
GlobalTracer [baseline] (235.077 ms) : 0, 235077
GlobalTracer [candidate] (235.279 ms) : 0, 235279
IAST [baseline] (22.07 ms) : 0, 22070
IAST [candidate] (21.9 ms) : 0, 21900
AppSec [baseline] (169.932 ms) : 0, 169932
AppSec [candidate] (169.422 ms) : 0, 169422
Debugger [baseline] (5.796 ms) : 0, 5796
Debugger [candidate] (5.777 ms) : 0, 5777
Remote Config [baseline] (600.59 µs) : 0, 601
Remote Config [candidate] (617.397 µs) : 0, 617
Telemetry [baseline] (8.104 ms) : 0, 8104
Telemetry [candidate] (8.112 ms) : 0, 8112
section iast
BytebuddyAgent [baseline] (813.268 ms) : 0, 813268
BytebuddyAgent [candidate] (809.156 ms) : 0, 809156
GlobalTracer [baseline] (234.146 ms) : 0, 234146
GlobalTracer [candidate] (232.681 ms) : 0, 232681
IAST [baseline] (27.961 ms) : 0, 27961
IAST [candidate] (27.762 ms) : 0, 27762
AppSec [baseline] (28.019 ms) : 0, 28019
AppSec [candidate] (27.821 ms) : 0, 27821
Debugger [baseline] (5.847 ms) : 0, 5847
Debugger [candidate] (5.793 ms) : 0, 5793
Remote Config [baseline] (584.062 µs) : 0, 584
Remote Config [candidate] (582.959 µs) : 0, 583
Telemetry [baseline] (8.031 ms) : 0, 8031
Telemetry [candidate] (7.897 ms) : 0, 7897
section profiling
BytebuddyAgent [baseline] (676.911 ms) : 0, 676911
BytebuddyAgent [candidate] (677.683 ms) : 0, 677683
GlobalTracer [baseline] (360.773 ms) : 0, 360773
GlobalTracer [candidate] (361.395 ms) : 0, 361395
AppSec [baseline] (33.662 ms) : 0, 33662
AppSec [candidate] (33.708 ms) : 0, 33708
Debugger [baseline] (9.715 ms) : 0, 9715
Debugger [candidate] (8.509 ms) : 0, 8509
Remote Config [baseline] (652.818 µs) : 0, 653
Remote Config [candidate] (666.154 µs) : 0, 666
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (9.538 ms) : 0, 9538
ProfilingAgent [baseline] (103.08 ms) : 0, 103080
ProfilingAgent [candidate] (102.412 ms) : 0, 102412
Profiling [baseline] (103.104 ms) : 0, 103104
Profiling [candidate] (102.437 ms) : 0, 102437

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	sezen.leblay/APPSEC-56480-config_errors
git_commit_date	1750857432	1750859729
git_commit_sha	`2f749a9`	8434d39cfc
release_version	1.51.0-SNAPSHOT~2f749a97c7	1.51.0-SNAPSHOT~d8434d39cfc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1750860666	1750860666
ci_job_id	998007486	998007486
ci_pipeline_id	68731460	68731460
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-vaym2f8s-project-304-concurrent-0-3ykjm1jx 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-vaym2f8s-project-304-concurrent-0-3ykjm1jx 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:code_origins:high_load	worse [+0.974ms; +1.814ms] or [+2.162%; +4.026%]	unstable [-7.594op/s; +6.383op/s] or [-7.311%; +6.144%]	46.447ms	103.269op/s	45.053ms	103.875op/s
scenario:load:petclinic:tracing:high_load	better [-2.764ms; -1.975ms] or [-6.195%; -4.426%]	unstable [-0.372op/s; +14.724op/s] or [-0.354%; +14.034%]	42.248ms	112.089op/s	44.618ms	104.912op/s
scenario:load:petclinic:profiling:high_load	worse [+1.106ms; +2.096ms] or [+2.296%; +4.352%]	unstable [-10.446op/s; +4.171op/s] or [-10.753%; +4.294%]	49.773ms	94.013op/s	48.172ms	97.150op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.042 ms) : 36754, 37330
.   : milestone, 37042,
appsec (47.587 ms) : 47168, 48007
.   : milestone, 47587,
code_origins (45.053 ms) : 44692, 45413
.   : milestone, 45053,
iast (44.356 ms) : 43971, 44741
.   : milestone, 44356,
profiling (48.172 ms) : 47724, 48620
.   : milestone, 48172,
tracing (44.618 ms) : 44236, 45000
.   : milestone, 44618,
section candidate
no_agent (36.913 ms) : 36619, 37206
.   : milestone, 36913,
appsec (48.366 ms) : 47940, 48792
.   : milestone, 48366,
code_origins (46.447 ms) : 46029, 46864
.   : milestone, 46447,
iast (45.293 ms) : 44909, 45677
.   : milestone, 45293,
profiling (49.773 ms) : 49301, 50245
.   : milestone, 49773,
tracing (42.248 ms) : 41898, 42599
.   : milestone, 42248,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.042 ms [36.754 ms, 37.33 ms]	-
appsec	47.587 ms [47.168 ms, 48.007 ms]	10.545 ms (28.5%)
code_origins	45.053 ms [44.692 ms, 45.413 ms]	8.011 ms (21.6%)
iast	44.356 ms [43.971 ms, 44.741 ms]	7.314 ms (19.7%)
profiling	48.172 ms [47.724 ms, 48.62 ms]	11.13 ms (30.0%)
tracing	44.618 ms [44.236 ms, 45.0 ms]	7.576 ms (20.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.913 ms [36.619 ms, 37.206 ms]	-
appsec	48.366 ms [47.94 ms, 48.792 ms]	11.453 ms (31.0%)
code_origins	46.447 ms [46.029 ms, 46.864 ms]	9.534 ms (25.8%)
iast	45.293 ms [44.909 ms, 45.677 ms]	8.38 ms (22.7%)
profiling	49.773 ms [49.301 ms, 50.245 ms]	12.86 ms (34.8%)
tracing	42.248 ms [41.898 ms, 42.599 ms]	5.335 ms (14.5%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~d8434d39cfc, baseline=1.51.0-SNAPSHOT~2f749a97c7
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.312 ms) : 4262, 4362
.   : milestone, 4312,
iast (9.19 ms) : 9040, 9340
.   : milestone, 9190,
iast_FULL (13.939 ms) : 13657, 14221
.   : milestone, 13939,
iast_GLOBAL (10.255 ms) : 10075, 10436
.   : milestone, 10255,
profiling (8.638 ms) : 8503, 8773
.   : milestone, 8638,
tracing (7.775 ms) : 7664, 7886
.   : milestone, 7775,
section candidate
no_agent (4.364 ms) : 4313, 4416
.   : milestone, 4364,
iast (9.164 ms) : 9016, 9313
.   : milestone, 9164,
iast_FULL (13.657 ms) : 13392, 13922
.   : milestone, 13657,
iast_GLOBAL (10.265 ms) : 10085, 10444
.   : milestone, 10265,
profiling (8.579 ms) : 8430, 8729
.   : milestone, 8579,
tracing (7.658 ms) : 7541, 7774
.   : milestone, 7658,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.312 ms [4.262 ms, 4.362 ms]	-
iast	9.19 ms [9.04 ms, 9.34 ms]	4.879 ms (113.2%)
iast_FULL	13.939 ms [13.657 ms, 14.221 ms]	9.627 ms (223.3%)
iast_GLOBAL	10.255 ms [10.075 ms, 10.436 ms]	5.944 ms (137.8%)
profiling	8.638 ms [8.503 ms, 8.773 ms]	4.326 ms (100.3%)
tracing	7.775 ms [7.664 ms, 7.886 ms]	3.464 ms (80.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.364 ms [4.313 ms, 4.416 ms]	-
iast	9.164 ms [9.016 ms, 9.313 ms]	4.8 ms (110.0%)
iast_FULL	13.657 ms [13.392 ms, 13.922 ms]	9.293 ms (212.9%)
iast_GLOBAL	10.265 ms [10.085 ms, 10.444 ms]	5.901 ms (135.2%)
profiling	8.579 ms [8.43 ms, 8.729 ms]	4.215 ms (96.6%)
tracing	7.658 ms [7.541 ms, 7.774 ms]	3.293 ms (75.5%)

Dacapo

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/test/StubAppSecConfigService.groovy

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java

github-actions · 2025-06-01T03:29:27Z

This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it.

Signed-off-by: sezen.leblay <[email protected]>

manuel-alvarez-alvarez

LGTM

completely changed the pr

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.39.0` -> `2.40.0` | | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source](https://gitbox.apache.org/repos/asf/commons-lang.git)) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.17.0` -> `3.18.0` | | [org.jetbrains.kotlinx.binary-compatibility-validator](https://github.com/Kotlin/binary-compatibility-validator) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `0.18.0` -> `0.18.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.50.1` -> `1.51.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.77` -> `2.31.78` | --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.40.0`](https://github.com/google/error-prone/releases/tag/v2.40.0): Error Prone 2.40.0 Changes: - Bug fixes and improvements - Releases (including snapshots) have migrated from [OSSRH to the Central Publisher Portal](https://central.sonatype.org/pages/ossrh-eol/#process-to-migrate) Full changelog: google/error-prone@v2.39.0...v2.40.0 </details> <details> <summary>Kotlin/binary-compatibility-validator (org.jetbrains.kotlinx.binary-compatibility-validator)</summary> ### [`v0.18.1`](https://github.com/Kotlin/binary-compatibility-validator/releases/tag/0.18.1) [Compare Source](Kotlin/binary-compatibility-validator@0.18.0...0.18.1) #### What's Changed - Fixed a bug preventing use of cross-compilation support during KLIB dump validation \[[#304](https://github.com/Kotlin/binary-compatibility-validator/issues/304)]\[[#306](https://github.com/Kotlin/binary-compatibility-validator/issues/306)] </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.0): 1.51.0 ### Components #### Application Security Management (IAST) - 🐛 Fix verify error when ctor params are used after a call site ([#9083](DataDog/dd-trace-java#9083) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Limit the maximum size of the location path in IAST vulnerabilities ([#9028](DataDog/dd-trace-java#9028) - [@jandro996](https://github.com/jandro996)) - 🐛 Fix IAST gRPC handler with null superclass ([#8984](DataDog/dd-trace-java#8984) - [@smola](https://github.com/smola)) - ✨ Optimize IAST Vulnerability Detection ([#8885](DataDog/dd-trace-java#8885) - [@jandro996](https://github.com/jandro996)) #### Application Security Management (WAF) - ✨ Upgrade libddwaf-java to 15.0.0 ([#9022](DataDog/dd-trace-java#9022) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Extract RestEasy json body response schemas ([#9015](DataDog/dd-trace-java#9015) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Enable API Security by default and make it lazy loading ([#9009](DataDog/dd-trace-java#9009) - [@smola](https://github.com/smola)) - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix Jackson nodes introspection for request/response schema extraction ([#8980](DataDog/dd-trace-java#8980) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Default obfuscation regexp update ([#8937](DataDog/dd-trace-java#8937) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Build & Tooling - ✨ Cancel GitLab running pipeline on new PR push ([#9023](DataDog/dd-trace-java#9023) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Migrate publishing to Maven Central Portal ([#8807](DataDog/dd-trace-java#8807) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - 🐛 Fix Test Optimization to work with JDK 24 ([#9114](DataDog/dd-trace-java#9114) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add repo root as safe directory on git client creation ([#9033](DataDog/dd-trace-java#9033) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add PR number tag and improve PR information building ([#8990](DataDog/dd-trace-java#8990) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update impacted tests logic ([#8923](DataDog/dd-trace-java#8923) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 🧹 Clean up DSM context injection ([#8776](DataDog/dd-trace-java#8776) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Database Monitoring - 🐛 Set trace\_injected in try block ([#9025](DataDog/dd-trace-java#9025) - [@natashadada](https://github.com/natashadada)) #### Dynamic Instrumentation - 🐛 Add source file tracking enable option ([#9115](DataDog/dd-trace-java#9115) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add java.util.Date support ([#9111](DataDog/dd-trace-java#9111) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update file probe format ([#9047](DataDog/dd-trace-java#9047) - [@jpbempel](https://github.com/jpbempel)) - ✨ add safe local var hoisting ([#9034](DataDog/dd-trace-java#9034) - [@jpbempel](https://github.com/jpbempel)) - 🧹 Add new config for debugger upload interval ([#8959](DataDog/dd-trace-java#8959) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enable Code Origin with Dynamic instrumentation ([#8940](DataDog/dd-trace-java#8940) - [@jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - 💡 LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang), [@nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - 🐛 Ensure client stat reporter is started when the agent is not available at bootstrap ([#9082](DataDog/dd-trace-java#9082) - [@amarziali](https://github.com/amarziali)) - ✨ Create metric: appsec.waf.config\_errors ([#8394](DataDog/dd-trace-java#8394) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Platform components - ✨ Introduce environment component ([#9071](DataDog/dd-trace-java#9071) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - 🐛 Remove annoying warning for smap event parsing ([#9119](DataDog/dd-trace-java#9119) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Fix ByteCountingInputStream when reading past EOF ([#8988](DataDog/dd-trace-java#8988) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Realtime User Monitoring - ✨ Add RUM SDK injection for servlet based web servers ([#9110](DataDog/dd-trace-java#9110) - [@PerfectSlayer](https://github.com/PerfectSlayer) [@amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Update the config origin metric to match what it's mapping ([#9045](DataDog/dd-trace-java#9045) - [@sezen-datadog](https://github.com/sezen-datadog)) #### Testing - ✨ Add testing for latest stable version (JDK 24) ([#8875](DataDog/dd-trace-java#8875) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Fix bug with dropping baggage when `TracePropagationBehaviorExtract=IGNORE` ([#9037](DataDog/dd-trace-java#9037) - [@mhlidd](https://github.com/mhlidd)) - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#9032](DataDog/dd-trace-java#9032) - [@mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Fix `Error` handling for trace interceptors ([#9097](DataDog/dd-trace-java#9097) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add wildcard feature for `DD_TRACE_HEADER_TAGS` and enabling for Http Response headers ([#9067](DataDog/dd-trace-java#9067) - [@mhlidd](https://github.com/mhlidd)) #### Tracer public API - 💡 Add LLM Observability SDK ([#8781](DataDog/dd-trace-java#8781) - [@gary-huang](https://github.com/gary-huang)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#9019](DataDog/dd-trace-java#9019) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - ✨ Extract Vert.x json body response schemas ([#9001](DataDog/dd-trace-java#9001) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Write http.route tag as soon as possible in vert.x ([#8952](DataDog/dd-trace-java#8952) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### JAX-WS instrumentation - 💡⚠️ Enable jax-ws integration by default ([#9030](DataDog/dd-trace-java#9030) - [@bm1549](https://github.com/bm1549)) - ✨ Extract Jersey json body response schemas ([#9014](DataDog/dd-trace-java#9014) - [@jandro996](https://github.com/jandro996)) #### Mule instrumentation - 🐛 Propagate grizzly http span in filters if nothing is active ([#9016](DataDog/dd-trace-java#9016) - [@amarziali](https://github.com/amarziali)) #### Play Framework instrumentation - ✨ Extract Play json body response schemas ([#8995](DataDog/dd-trace-java#8995) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Ratpack instrumentation - ✨ Extract Ratpack json body response schemas ([#9013](DataDog/dd-trace-java#9013) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Spring instrumentation - ✨ Extract Spring json body response schemas ([#8938](DataDog/dd-trace-java#8938) - [@sezen-datadog](https://github.com/sezen-datadog)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 649b690d4c9d7dcb572c457f0802b42b8e3e682e

sezen-datadog added type: enhancement Enhancements and improvements comp: metrics Metrics labels Feb 14, 2025

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 200de0f to 5358abc Compare February 17, 2025 09:28

sezen-datadog marked this pull request as ready for review February 17, 2025 09:28

sezen-datadog requested review from a team as code owners February 17, 2025 09:28

sezen-datadog requested review from smola and Mariovido February 17, 2025 09:28

smola requested changes Feb 17, 2025

View reviewed changes

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java Outdated Show resolved Hide resolved

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 3602794 to b81bc2b Compare February 17, 2025 13:03

sezen-datadog requested a review from smola February 17, 2025 13:23

smola requested changes Feb 17, 2025

View reviewed changes

dd-java-agent/appsec/src/main/java/com/datadog/appsec/gateway/AppSecRequestContext.java Outdated Show resolved Hide resolved

sezen-datadog requested a review from smola February 17, 2025 14:52

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 2a5843a to 58f7a0c Compare February 17, 2025 14:58

sezen-datadog enabled auto-merge (squash) February 17, 2025 14:59

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 58f7a0c to 325d88b Compare February 17, 2025 16:16

smola requested changes Feb 17, 2025

View reviewed changes

dd-java-agent/appsec/src/test/groovy/com/datadog/appsec/test/StubAppSecConfigService.groovy Outdated Show resolved Hide resolved

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java Outdated Show resolved Hide resolved

sezen-datadog marked this pull request as draft February 18, 2025 08:52

auto-merge was automatically disabled February 18, 2025 08:52
Pull request was converted to draft

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from d51336d to 66744d3 Compare February 18, 2025 15:58

sezen-datadog marked this pull request as ready for review February 19, 2025 08:34

sezen-datadog requested review from smola and manuel-alvarez-alvarez February 19, 2025 08:44

smola previously requested changes Feb 19, 2025

View reviewed changes

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java Outdated Show resolved Hide resolved

dd-java-agent/appsec/src/main/java/com/datadog/appsec/powerwaf/PowerWAFModule.java Outdated Show resolved Hide resolved

sezen-datadog marked this pull request as draft February 19, 2025 09:51

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from cfb9393 to b663d78 Compare February 19, 2025 10:55

github-actions bot added the tag: stale Stale pull requests label Jun 1, 2025

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 3765eb5 to 7b50728 Compare June 24, 2025 12:17

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch 4 times, most recently from 7021254 to b83d86c Compare June 25, 2025 11:00

sezen-datadog marked this pull request as ready for review June 25, 2025 11:04

sezen-datadog marked this pull request as draft June 25, 2025 11:05

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from b83d86c to 7b93f75 Compare June 25, 2025 11:09

Create metric appsec.waf.config_errors

022e3db

Signed-off-by: sezen.leblay <[email protected]>

sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 7b93f75 to 022e3db Compare June 25, 2025 11:10

sezen-datadog marked this pull request as ready for review June 25, 2025 11:10

sezen-datadog removed the tag: stale Stale pull requests label Jun 25, 2025

unit test

e1b7f27

Signed-off-by: sezen.leblay <[email protected]>

sezen-datadog requested a review from smola June 25, 2025 13:16

manuel-alvarez-alvarez approved these changes Jun 25, 2025

View reviewed changes

sezen-datadog enabled auto-merge (squash) June 25, 2025 13:42

Merge branch 'master' into sezen.leblay/APPSEC-56480-config_errors

d8434d3

sezen-datadog merged commit becbf2a into master Jun 26, 2025
485 checks passed

sezen-datadog deleted the sezen.leblay/APPSEC-56480-config_errors branch June 26, 2025 06:42

github-actions bot added this to the 1.51.0 milestone Jun 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create metric: appsec.waf.config_errors #8394

Create metric: appsec.waf.config_errors #8394

Uh oh!

sezen-datadog commented Feb 14, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Feb 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

Uh oh!

Uh oh!

Create metric: appsec.waf.config_errors #8394

Create metric: appsec.waf.config_errors #8394

Uh oh!

Conversation

sezen-datadog commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 1, 2025

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sezen-datadog commented Feb 14, 2025 •

edited

Loading

pr-commenter bot commented Feb 14, 2025 •

edited

Loading