Conversation
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
📝 WalkthroughWalkthroughSpanish localization files updated across commands, main UI, and settings with improved translation terminology, consistency corrections, and structural enhancements. MediaAssets property restructured from simple string to rich object containing sorting and filtering metadata for multimedia resources. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
🎨 Storybook:
|
🎭 Playwright: ✅ 633 passed, 0 failed · 3 flaky📊 Browser Reports
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/locales/es/commands.json (1)
1-370:⚠️ Potential issue | 🟡 MinorRemove manual edits to non-English locale files.
Lines 1–370 modify
src/locales/es/commands.json, a non-English locale file that is auto-generated on every release in this repository. Manual updates to non-English locales (es, fr, ja, ko, ru, zh, zh-TW, ar, tr, pt-BR, fa) will be overwritten and do not persist. Only modifysrc/locales/en/commands.jsonin PRs; translations for other languages are handled automatically during the release pipeline.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/locales/es/commands.json` around lines 1 - 370, This change edits auto-generated non-English locale keys (e.g., "Comfy-Desktop_CheckForUpdates", "Workspace_ToggleSidebarTab_assets", etc.); revert all manual modifications in the es locale file so it matches the upstream/generated version (remove the added/edited labels), and ensure any intended text changes are applied only to the English source locale (the en commands.json) instead of altering non-English locale files.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/locales/es/settings.json`:
- Around line 244-249: Add the missing Spanish tooltip entries for the two new
settings by extending the Comfy_Node_MiddleClickRerouteNode and
Comfy_Node_Opacity objects to include a "tooltip" field with the Spanish
translations (match the English locale intent); update the JSON keys
"Comfy_Node_MiddleClickRerouteNode.tooltip" and "Comfy_Node_Opacity.tooltip"
with appropriate Spanish text so the UI no longer falls back to English. Ensure
the strings are valid JSON values and follow the same phrasing style as other
locale entries.
---
Outside diff comments:
In `@src/locales/es/commands.json`:
- Around line 1-370: This change edits auto-generated non-English locale keys
(e.g., "Comfy-Desktop_CheckForUpdates", "Workspace_ToggleSidebarTab_assets",
etc.); revert all manual modifications in the es locale file so it matches the
upstream/generated version (remove the added/edited labels), and ensure any
intended text changes are applied only to the English source locale (the en
commands.json) instead of altering non-English locale files.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9ed8fa4c-15ec-49b8-a122-7a033c5e70a2
📒 Files selected for processing (4)
src/locales/es/commands.jsonsrc/locales/es/main.jsonsrc/locales/es/nodeDefs.jsonsrc/locales/es/settings.json
| "Comfy_Node_MiddleClickRerouteNode": { | ||
| "name": "El clic medio crea un nuevo nodo de reenrutamiento" | ||
| }, | ||
| "Comfy_Node_Opacity": { | ||
| "name": "Opacidad del nodo" | ||
| }, |
There was a problem hiding this comment.
Add missing Spanish tooltips for two new node settings.
Line 244 (Comfy_Node_MiddleClickRerouteNode) and Line 247 (Comfy_Node_Opacity) define name only, while the English locale includes tooltips for both. This can produce fallback/mixed-language UI.
💡 Proposed fix
"Comfy_Node_MiddleClickRerouteNode": {
- "name": "El clic medio crea un nuevo nodo de reenrutamiento"
+ "name": "El clic medio crea un nuevo nodo de reenrutamiento",
+ "tooltip": "Haz clic con el botón central en los enlaces para crear nodos de reenrutamiento."
},
"Comfy_Node_Opacity": {
- "name": "Opacidad del nodo"
+ "name": "Opacidad del nodo",
+ "tooltip": "Opacidad de los nodos en el lienzo (0 = completamente transparente, 1 = completamente opaco)."
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Comfy_Node_MiddleClickRerouteNode": { | |
| "name": "El clic medio crea un nuevo nodo de reenrutamiento" | |
| }, | |
| "Comfy_Node_Opacity": { | |
| "name": "Opacidad del nodo" | |
| }, | |
| "Comfy_Node_MiddleClickRerouteNode": { | |
| "name": "El clic medio crea un nuevo nodo de reenrutamiento", | |
| "tooltip": "Haz clic con el botón central en los enlaces para crear nodos de reenrutamiento." | |
| }, | |
| "Comfy_Node_Opacity": { | |
| "name": "Opacidad del nodo", | |
| "tooltip": "Opacidad de los nodos en el lienzo (0 = completamente transparente, 1 = completamente opaco)." | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/es/settings.json` around lines 244 - 249, Add the missing Spanish
tooltip entries for the two new settings by extending the
Comfy_Node_MiddleClickRerouteNode and Comfy_Node_Opacity objects to include a
"tooltip" field with the Spanish translations (match the English locale intent);
update the JSON keys "Comfy_Node_MiddleClickRerouteNode.tooltip" and
"Comfy_Node_Opacity.tooltip" with appropriate Spanish text so the UI no longer
falls back to English. Ensure the strings are valid JSON values and follow the
same phrasing style as other locale entries.
1 participant
Summary
Improve spanish translations.
Changes
┆Issue is synchronized with this Notion page by Unito