Skip to content

Issue: Core side expects also a double click for a triple click event. #13921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gokaysatir wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −19
Open

Issue: Core side expects also a double click for a triple click event. #13921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions browser/src/canvas/sections/MouseControl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,8 @@ class MouseControl extends CanvasSectionObject {

if (!(<any>window).mode.isDesktop()) app.map.fire('closemobilewizard');

if (this.clickCount > 4) return;

// Right click is not supported. And click event doesn't have "buttons" property set. Safe to set it here to default.
let buttons = app.LOButtons.left;

Expand All @@ -431,22 +433,6 @@ class MouseControl extends CanvasSectionObject {

if (this.clickTimer) clearTimeout(this.clickTimer);
else {
// Old code always sends the first click, so do we.
this.postCoreMouseEvent(
'buttondown',
sendingPosition,
1,
buttons,
modifier,
);
this.postCoreMouseEvent(
'buttonup',
sendingPosition,
1,
buttons,
modifier,
);

// For future: Here, we are checking the window size to determine the view mode, we can also check the event type (touch/click).
app.map.focus(
(<any>window).mode.isDesktop()
Expand All @@ -456,18 +442,18 @@ class MouseControl extends CanvasSectionObject {
}

this.clickTimer = setTimeout(() => {
if (this.clickCount > 1) {
for (let i = 0; i < this.clickCount; i++) {
this.postCoreMouseEvent(
'buttondown',
sendingPosition,
this.clickCount,
i + 1,
buttons,
modifier,
);
this.postCoreMouseEvent(
'buttonup',
sendingPosition,
this.clickCount,
i + 1,
buttons,
modifier,
);
Expand Down
Loading