Issue: Core side expects also a double click for a triple click event. #13921
+5
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calc: When user triple clicks on a cell, editing session should start and the cell content should get selected. Current state: New code assumes that double click is not required for a triple click event. Fix: Send all the click events. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I381b75be868ea5bb0b9beabf636bf19b8eb3b116
gokaysatir
force-pushed
the
private/gokay/calc-triple-click
branch
from
783f817 to
c670ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calc: When user triple clicks on a cell, editing session should start and the cell content should get selected.
Current state: New code assumes that double click is not required for a triple click event.
Fix: Send all the click events.
Change-Id: I381b75be868ea5bb0b9beabf636bf19b8eb3b116
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay