-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Export entrypoint metadata in Python and fix bug in import #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2434 +/- ##
=======================================
Coverage 82.56% 82.56%
=======================================
Files 247 247
Lines 45894 45900 +6
Branches 41528 41528
=======================================
+ Hits 37891 37897 +6
Misses 5981 5981
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2749fb7
to
dc50cc2
Compare
Either split in to two PRs or include both changes in PR title (otherwise second is lost in changelog) |
Edited the title since it makes sense to keep them together: the metadata export from Python unearthed the bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the behaviour of the standalone
arg. A docstring addition might help.
1aa3b34
to
11c60e3
Compare
11c60e3
to
41480bd
Compare
The |
This PR ensures that the
core.entrypoint
metadata is exported in the Python bindings. It also fixes a bug inhugr-core
import that added children of the root node to the entrypoint instead of the root.