Caught logic error: Entrypoint metadata needs to be on the region, not on the node.

Author: zrho

hugr-py/src/hugr/model/export.py

@@ -75,15 +75,14 @@ def export_node(
 
         outputs = [self.link_name(OutPort(node, i)) for i in range(node_data._num_outs)]
         meta = self.export_json_meta(node)
-        meta += self.export_entrypoint_meta(node)
 
         # Add an order hint key to the node if necessary
         if _has_order_links(self.hugr, node):
             meta.append(model.Apply("core.order_hint.key", [model.Literal(node.idx)]))
 
         match node_data.op:
             case DFG() as op:
-                region = self.export_region_dfg(node, standalone=False)
+                region = self.export_region_dfg(node)
 
                 return model.Node(
                     operation=model.Dfg(),
@@ -124,7 +123,7 @@ def export_node(
 
             case Conditional() as op:
                 regions = [
-                    self.export_region_dfg(child, standalone=True)
+                    self.export_region_dfg(child)
                     for child in node_data.children
                 ]
 
@@ -140,7 +139,7 @@ def export_node(
                 )
 
             case TailLoop() as op:
-                region = self.export_region_dfg(node, standalone=False)
+                region = self.export_region_dfg(node)
                 signature = op.outer_signature().to_model()
                 return model.Node(
                     operation=model.TailLoop(),
@@ -156,7 +155,7 @@ def export_node(
                 symbol = self.export_symbol(
                     name, op.visibility, op.signature.params, op.signature.body
                 )
-                region = self.export_region_dfg(node, standalone=False)
+                region = self.export_region_dfg(node)
 
                 return model.Node(
                     operation=model.DefineFunc(symbol), regions=[region], meta=meta
@@ -322,7 +321,7 @@ def export_node(
                 )
 
             case DataflowBlock() as op:
-                region = self.export_region_dfg(node, standalone=False)
+                region = self.export_region_dfg(node)
 
                 input_types = [model.List([type.to_model() for type in op.inputs])]
 
@@ -419,7 +418,7 @@ def export_region_module(self, node: Node) -> model.Region:
 
         return model.Region(kind=model.RegionKind.MODULE, children=children, meta=meta)
 
-    def export_region_dfg(self, node: Node, standalone: bool = True) -> model.Region:
+    def export_region_dfg(self, node: Node) -> model.Region:
         """Export the children of a node as a dataflow region."""
         node_data = self.hugr[node]
         children: list[model.Node] = []
@@ -428,7 +427,7 @@ def export_region_dfg(self, node: Node, standalone: bool = True) -> model.Region
         sources = []
         targets = []
 
-        meta = self.export_entrypoint_meta(node) if standalone else []
+        meta = self.export_entrypoint_meta(node)
 
         for child in node_data.children:
             child_data = self.hugr[child]