-
Notifications
You must be signed in to change notification settings - Fork 22
Add TotalCommonConditionedAboveGradeWallArea #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f3056c9
prop: add DemisingAboveGradeWallArea to Building
JieXiong9119 8c2d0da
Implementation of DemisingAboveGradeWallArea in schema
JieXiong9119 eea1c9c
Merge branch 'develop' into proposals/demising-above-grade-wall-area
JieXiong9119 2bb5431
Changing terms and names
JieXiong9119 88becc2
Merge branch 'develop' into proposals/demising-above-grade-wall-area
nllong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
proposals/2021/Add TotalCommonConditionedAboveGradeWallArea.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
# Add TotalCommonConditionedAboveGradeWallArea | ||
|
||
## Overview | ||
|
||
This proposal is to add the `TotalCommonConditionedAboveGradeWallArea` child element under the `Building` element. This captures the total area of the above grade wall common with other conditioned buildings. | ||
|
||
## Justification | ||
|
||
Audit Template Tool defines demising wall as the total area of the above grade wall common with other conditioned buildings, as an overall building characteristic. However, the term demising wall has conflicting definition in other standards (such as interior partitions). To avoid ambiguity, we adopt the descriptive name `TotalCommonConditionedAboveGradeWallArea` instead of `DemisingAboveGradeWallArea`. | ||
|
||
### UDFs | ||
Currently, this is conveyed in Audit template via: `/auc:BuildingSync/auc:Facilities/auc:Facility/auc:Sites/auc:Site/auc:Buildings/auc:Building/auc:UserDefinedFields/auc:UserDefinedField[auc:FieldName/text() = Demising Above Grade Wall Area]/auc:FieldValue`. Our proposal is that it would rather look like: | ||
|
||
```xml | ||
|
||
<Facilities> | ||
<Facility ID="F1"> | ||
<Sites> | ||
<Site> | ||
<Buildings> | ||
<Building ID="G1"> | ||
<TotalCommonConditionedAboveGradeWallArea>1000</TotalCommonConditionedAboveGradeWallArea> | ||
</Building> | ||
</Buildings> | ||
</Site> | ||
</Sites> | ||
</Facility> | ||
</Facilities> | ||
|
||
``` | ||
|
||
## Implementation | ||
|
||
```xml | ||
|
||
<xs:element name="Buildings" minOccurs="0"> | ||
<xs:complexType> | ||
<xs:sequence> | ||
<xs:element name="Building" type="auc:BuildingType" maxOccurs="unbounded"> | ||
<xs:annotation> | ||
<xs:documentation>A building is a single structure wholly or partially enclosed within exterior walls, or within exterior and abutment walls (party walls), and a roof, affording shelter to persons, animals, or property. A building can be two or more units held in the condominium form of ownership that are governed by the same board of managers.</xs:documentation> | ||
</xs:annotation> | ||
</xs:element> | ||
</xs:sequence> | ||
</xs:complexType> | ||
</xs:element> | ||
... | ||
<xs:element name="TotalCommonConditionedAboveGradeWallArea" minOccurs="0"> | ||
<xs:annotation> | ||
<xs:documentation>The total area of the above grade wall common with other conditioned buildings. (ft2)</xs:documentation> | ||
</xs:annotation> | ||
<xs:complexType> | ||
<xs:simpleContent> | ||
<xs:extension base="auc:nonNegativeDecimal"> | ||
<xs:attribute ref="auc:Source"/> | ||
</xs:extension> | ||
</xs:simpleContent> | ||
</xs:complexType> | ||
</xs:element> | ||
... | ||
``` | ||
|
||
## References | ||
https://help.buildingenergyscore.com/support/solutions/articles/8000053362-facility-description-construction (even though their usage of the term demising wall is incorrect) | ||
ASHRAE Standard 211 6.2.1.2.b |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to reverence the ASHRAE standard here. If you search in the schema there are a few places where we do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you point me to those places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an example:
schema/BuildingSync.xsd
Line 4106 in 458dcc2