Add TotalCommonConditionedAboveGradeWallArea #306
Conversation
JieXiong9119
added
Non-breaking Change
feature
JieXiong9119
requested review from
nllong,
yan130,
macintoshpie,
corymosiman12 and
aviveiros11
| @@ -796,6 +796,18 @@ | |||
| </xs:simpleContent> | |||
| </xs:complexType> | |||
| </xs:element> | |||
| <xs:element name="DemisingAboveGradeWallArea" minOccurs="0"> | |||
| <xs:annotation> | |||
| <xs:documentation>Above grade demising wall area. (ft2)</xs:documentation> | |||
There was a problem hiding this comment.
We might want to reverence the ASHRAE standard here. If you search in the schema there are a few places where we do this
There was a problem hiding this comment.
We might want to reverence the ASHRAE standard here. If you search in the schema there are a few places where we do this
Could you point me to those places?
There was a problem hiding this comment.
Here's an example:
Line 4106 in 458dcc2
BuildingSync.xsd
Outdated
| @@ -796,6 +796,18 @@ | |||
| </xs:simpleContent> | |||
| </xs:complexType> | |||
| </xs:element> | |||
| <xs:element name="DemisingAboveGradeWallArea" minOccurs="0"> | |||
There was a problem hiding this comment.
I propose changing the element name to: TotalCommonConditionedAboveGradeWallArea and the documentation to: The total area of the above grade wall common with other conditioned buildings
| </xs:annotation> | ||
| <xs:complexType> | ||
| <xs:simpleContent> | ||
| <xs:extension base="xs:decimal"> |
There was a problem hiding this comment.
Jie let's also add this as a non negative decimal.
| ``` | ||
|
|
||
| ## References | ||
| https://www.pnnl.gov/main/publications/external/technical_reports/PNNL-25130.pdf |
There was a problem hiding this comment.
For reference, you can use:
- https://help.buildingenergyscore.com/support/solutions/articles/8000053362-facility-description-construction (even though their usage of the term demising wall is incorrect)
- ASHRAE Standard 211 6.2.1.2.b
1. Changed `DemisingAboveGradeWallArea` to `TotalCommonConditionedAboveGradeWallArea`. 2. Clarified definition and description.
| <Site> | ||
| <Buildings> | ||
| <Building ID="G1"> | ||
| <DemisingAboveGradeWallArea>1000</DemisingAboveGradeWallArea> |
There was a problem hiding this comment.
Maybe we should use 1000.0 instead of 1000?
Our XML has such format.
There was a problem hiding this comment.
The value is set to nonNegativeDecimal. So this is just a visual thing.
JieXiong9119
changed the title
See proposal
Implementation in schema added