Fixes issue 160

[freddyC]

• Verified changes
• Tests, coverage, ran, checked

Description

Because Infinity is not valid json it gets serialized as null. We didn't catch this anywhere because we were

1. Using specific values in the json tests (not the default Infinity)
2. Not actually serializing the json object, just using it as a javascript object.

I updated the Neural Network class to handle this when deserializing.

I also updated the tests to both check defaults and serialize the value.

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

• My code focuses on the main motivation and avoids scope creep.
• My code passes current tests and adds new tests where possible.
• My code is SOLID and DRY.
• [] I have updated the documentation as needed.

Reviewer's Checklist:

• I kept my comments to the author positive, specific, and productive.
• I tested the code and didn't find any new problems.
• I think the motivation is good for the project.
• I think the code works to satisfies the motivation.

[robertleeplummerjr]

The problem with the approach is that it modifies the object being sent into brain. This is where I would have went as well, but it may be more advantagoes to do something like this, so as to ensure we aren't changing any values:

if (json.hasOwnProperty('trainOpts')) {
  this._updateTrainingOptions({
    ...json.trainOpts,
    timeout: json.trainOpts.timeout === null ? Infinity : json.trainOpts.timeout
  });
}

This allows us to handle the exact situation where timeout is parsed to null, and treated as infinity, but has no side effects of altering the object the is sent to us.

[robertleeplummerjr]

🚀 it