[InspectorV2/Fluent] Various new features/fixes from our muster munday madness #16967
Conversation
…dd linktonodepropertyline, ensure dropdown works with nullalbes
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
packages/dev/inspector-v2/src/components/properties/animation/animationGroupProperties.tsx
Show resolved
Hide resolved
…ather than empty textpropertyline
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16967/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16967/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16967/merge#BCU1XR#0 |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16967/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16967/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
packages/dev/sharedUiComponents/src/fluent/hoc/propertyLines/propertyLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/propertyLines/dropdownPropertyLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/properties/animation/animationGroupProperties.tsx
Show resolved
Hide resolved
packages/dev/inspector-v2/src/components/scene/sceneExplorer.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/propertyLines/propertyLine.tsx
Show resolved
Hide resolved
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16967/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16967/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16967/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16967/merge/ |
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
1 similar comment
|
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16967/merge/testResults/ |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16967/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16967/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
…y madness (BabylonJS#16967) - BoundProperty now has the option to send ignoreNullable in place of nullable. When sent, the underlying component will use the default value in an enabled state (vs the nullable behavior of showing a checkbox to set/unset null). You can see this being used in AnimationGroupProperties - DropdownPropertyLine now uses the type of options in order to infer the type of value/onChange (to avoid casting as foo). It also condenses the old logic of nullable foo to instead use the nullable checkbox feature of boundproperty <img width="239" height="84" alt="image" src="https://github.com/user-attachments/assets/35a496a1-8b60-40ab-98ed-64a9b584ee5f" /> <img width="217" height="60" alt="image" src="https://github.com/user-attachments/assets/8f926991-b47d-4b2d-b793-1f31664d4e48" /> - RegisterDataStore.hidden is now accounted for within sceneExplorer when determining an entity's visibility - Shared LinkToEntityPropertyLine that does the selection logic for an entity and encapsulates the check for whether node exists as well as the check for whether the entity has registeredDataStore.hidden - Use propertyLine directly for cases where we want a nested component available in the expanded content. And add some padding to expandedContent <img width="707" height="498" alt="image" src="https://github.com/user-attachments/assets/4f56d3e7-7c74-4e5d-b8c0-2b0069ee9acf" /> --------- Co-authored-by: Georgina <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.