Add multimaterial support to inspector v2 #16966
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16966/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16966/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16966/merge#BCU1XR#0 |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16966/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16966/merge/ |
|
Visualization tests for WebGPU |
packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx
Outdated
Show resolved
Hide resolved
…alPropertiesService.tsx
|
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
|
Building or testing the playground has failed. If the tests failed, results can be found here: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx
Outdated
Show resolved
Hide resolved
…alPropertiesService.tsx
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16966/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16966/merge/ |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
| return ( | ||
| <> | ||
| {multiMaterial.subMaterials.map((material, index) => ( | ||
| <LinkPropertyLine label={`Material #${index + 1}`} value={material!.name} onLink={() => (selectionService.selectedEntity = material)} /> |
There was a problem hiding this comment.
once this PR gets checked in your can use LinkToEntityPropertyLine
packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx
Outdated
Show resolved
Hide resolved
packages/dev/inspector-v2/src/services/panes/scene/materialExplorerService.tsx
Show resolved
Hide resolved
|
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16966/merge/ |
|
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16966/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
|
||
| return ( | ||
| <> | ||
| {multiMaterial.subMaterials.map((material, index) => ( |
There was a problem hiding this comment.
This is a case where using keys will be better. If the material list changes, this might yield wrong results, and even if it doesn't it will make reconciliation more efficient if keys are provided. The key could probably just be the unique id of the material.
Material explorer:
Children section in material properties:
