FIX: fix conda recipe and pip dependencies #130
Merged
+56
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So, are we ready to merge? |
* BCDA-APS#131 WIP * BCDA-APS#131 move definition to package init * BCDA-APS#131 WIP - problems with historydict * BCDA-APS#131 as recommended * BCDA-APS#131 sort (below dev requirements) * BCDA-APS#131 no need to package the requirements list * BCDA-APS#131 don't list requirements for run-time use
mrakitin
commented
May 7, 2019
Contributor
Author
mrakitin
left a comment
mrakitin
left a comment
There was a problem hiding this comment.
We forgot to implement 1 change regarding the databroker[all] line. Re-iterating here.
Contributor
Author
|
@prjemian, it's ready to go. Thanks for all your contributions via mrakitin#1. |
Contributor
Author
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #129.