PyPI package does not install dependencies

[mrakitin]

It looks like the package published at PyPI (https://pypi.org/project/apstools/) does not install the dependencies (databroker, etc.). The reason is an empty install_requires field in

apstools/setup.py

Line 35 in f6aa515

install_requires = package.__install_requires__,

caused by this block of code

apstools/apstools/__init__.py

Lines 28 to 29 in f6aa515

	__install_requires__ = ('databroker', 'pandas', 'xlrd')
	__install_requires__ = () # TODO: for conda build now

As far as I understand from the comment there, the conda recipe tries to install the deps from PyPI. To avoid this, change this line

apstools/conda-recipe/meta.yaml

Line 26 in f6aa515

script: python setup.py install

to something like

 script: python setup.py install --single-version-externally-managed --record=record.txt

(like in bluesky's recipe) or even to the conda-forge recommended way http://conda-forge.org/docs/maintainer/adding_pkgs.html#use-pip.

[prjemian]

Thanks for that. What about the record.txt file?

[mrakitin]

I think it's a legacy way of installing packages (which we still use) to keep the record of egg-files. See e.g. https://mythinkpond.com/2016/09/30/uninstall-python-eggs-that-you-installed-using-setup-py for the details. I changed the recipe in the PR to use pip (based on conda-build's documentation).

[mrakitin]

pip-package also misses `` pyRestTable:

$ bluesky_snapshot -h
/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/databroker/databroker.py:42: UserWarning: There was a error loading '_legacy_config': ModuleNotFoundError("No module named 'pymongo'",)
  warn("There was a error loading {!r}: {!r}".format(SPECIAL_NAME, exc))
Traceback (most recent call last):
  File "/home/mrakitin/conda_envs/apstools/bin/bluesky_snapshot", line 7, in <module>
    from apstools.snapshot import snapshot_cli
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/snapshot.py", line 51, in <module>
    from . import utils as APS_utils
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/utils.py", line 38, in <module>
    import pyRestTable
ModuleNotFoundError: No module named 'pyRestTable'

Also, pymongo wasn't found. It's an optional dependency of databroker, so __install_requires__ may need to be updated with 'databroker[all]'.

After those 2 deps were installed manually, I noticed that some plans were imported from bluesky. I think it should be a dependency as well.

[mrakitin]

$ bluesky_snapshot -h
Traceback (most recent call last):
  File "/home/mrakitin/conda_envs/apstools/bin/bluesky_snapshot", line 7, in <module>
    from apstools.snapshot import snapshot_cli
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/snapshot.py", line 51, in <module>
    from . import utils as APS_utils
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/utils.py", line 44, in <module>
    from .plans import run_in_thread
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/plans.py", line 34, in <module>
    from bluesky import preprocessors as bpp
ModuleNotFoundError: No module named 'bluesky'

[mrakitin]

OK, and now ophyd:

$ bluesky_snapshot -h
Traceback (most recent call last):
  File "/home/mrakitin/conda_envs/apstools/bin/bluesky_snapshot", line 7, in <module>
    from apstools.snapshot import snapshot_cli
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/snapshot.py", line 51, in <module>
    from . import utils as APS_utils
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/utils.py", line 44, in <module>
    from .plans import run_in_thread
  File "/home/mrakitin/conda_envs/apstools/lib/python3.6/site-packages/apstools/plans.py", line 38, in <module>
    import ophyd
ModuleNotFoundError: No module named 'ophyd'

[mrakitin]

I'd recommend placing all the deps to requirements.txt and read/parse this file in apstools/apstools/__init__.py, as now the requirements in 2 places are different, and requirements.txt is simply ignored.

[prjemian]

This is a great recommendation!