Skip to content

[ECP-9949] Fix TWINT tokenization #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shubhamk67 merged 2 commits into from
May 1, 2026
+4 −4
Merged

[ECP-9949] Fix TWINT tokenization #3300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de93c7
[ECP-9949] Fix TWINT tokenization
shubhamk67 Apr 30, 2026
74bc103
[ECP-9949] Use PaymentMethods InstantPurchase classes for TWINT vault
shubhamk67 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1729,15 +1729,15 @@
<supports_recurring>1</supports_recurring>
<supports_manual_capture>1</supports_manual_capture>
<supports_auto_capture>1</supports_auto_capture>
<is_wallet>1</is_wallet>
<is_wallet>0</is_wallet>

@gemini-code-assist gemini-code-assist Bot Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While reclassifying TWINT as a non-wallet payment method is correct to prevent card-related field errors, the adyen_twint_vault configuration for instant_purchase (lines 1739-1740) remains inconsistent. It still references card-specific classes (Adyen\Payment\Model\InstantPurchase\Card\AvailabilityChecker and Adyen\Payment\Model\InstantPurchase\Card\TokenFormatter). To ensure consistency and avoid potential issues during the instant purchase flow, these should be updated to use the PaymentMethods counterparts, similar to other non-wallet methods like PayPal or Klarna.

<group>adyen-alternative-payment-method</group>
</adyen_twint>
<adyen_twint_vault>
<title>Stored TWINT</title>
<model>AdyenPaymentTwintVaultFacade</model>
<instant_purchase>
<available>Adyen\Payment\Model\InstantPurchase\Card\AvailabilityChecker</available>
<tokenFormat>Adyen\Payment\Model\InstantPurchase\Card\TokenFormatter</tokenFormat>
<available>Adyen\Payment\Model\InstantPurchase\PaymentMethods\AvailabilityChecker</available>
<tokenFormat>Adyen\Payment\Model\InstantPurchase\PaymentMethods\TokenFormatter</tokenFormat>
</instant_purchase>
</adyen_twint_vault>
<adyen_walley>
Expand Down
2 changes: 1 addition & 1 deletion etc/frontend/di.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
<item name="adyen_klarna_paynow" xsi:type="object">Adyen\Payment\Model\Ui\PaymentMethodTokenUiComponentProvider</item>
<item name="adyen_paybybank" xsi:type="object">Adyen\Payment\Model\Ui\PaymentMethodTokenUiComponentProvider</item>
<item name="adyen_trustly" xsi:type="object">Adyen\Payment\Model\Ui\PaymentMethodTokenUiComponentProvider</item>
<item name="adyen_twint" xsi:type="object">Adyen\Payment\Model\Ui\CardTokenUiComponentProvider</item>
<item name="adyen_twint" xsi:type="object">Adyen\Payment\Model\Ui\PaymentMethodTokenUiComponentProvider</item>
<item name="adyen_zip" xsi:type="object">Adyen\Payment\Model\Ui\CardTokenUiComponentProvider</item>
<item name="adyen_gcash" xsi:type="object">Adyen\Payment\Model\Ui\CardTokenUiComponentProvider</item>
<item name="adyen_carnet" xsi:type="object">Adyen\Payment\Model\Ui\PaymentMethodTokenUiComponentProvider</item>
Expand Down
Loading