Skip to content

[ECP-9949] Fix TWINT tokenization#3300

Merged
shubhamk67 merged 2 commits into
mainfrom
ECP-9949
May 1, 2026
Merged

[ECP-9949] Fix TWINT tokenization#3300
shubhamk67 merged 2 commits into
mainfrom
ECP-9949

Conversation

@shubhamk67

Copy link
Copy Markdown
Contributor

Description
This PR reclassifies TWINT as a non-wallet payment method to prevent vault token errors caused by missing card-related fields in the Adyen response.

@shubhamk67 shubhamk67 requested a review from a team as a code owner April 30, 2026 09:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reclassifies the TWINT payment method by disabling its wallet status in the configuration and updating its UI component provider to a standard payment method provider. Feedback indicates that the adyen_twint_vault configuration for instant purchase remains inconsistent, as it still utilizes card-specific classes that should be updated to their payment method counterparts to ensure consistency with the reclassification.

Comment thread etc/config.xml
<supports_manual_capture>1</supports_manual_capture>
<supports_auto_capture>1</supports_auto_capture>
<is_wallet>1</is_wallet>
<is_wallet>0</is_wallet>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While reclassifying TWINT as a non-wallet payment method is correct to prevent card-related field errors, the adyen_twint_vault configuration for instant_purchase (lines 1739-1740) remains inconsistent. It still references card-specific classes (Adyen\Payment\Model\InstantPurchase\Card\AvailabilityChecker and Adyen\Payment\Model\InstantPurchase\Card\TokenFormatter). To ensure consistency and avoid potential issues during the instant purchase flow, these should be updated to use the PaymentMethods counterparts, similar to other non-wallet methods like PayPal or Klarna.

@sonarqubecloud

Copy link
Copy Markdown

@shubhamk67 shubhamk67 added the Fix Indicates a bug fix label Apr 30, 2026
@shubhamk67 shubhamk67 merged commit e047fd5 into main May 1, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Indicates a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants