Skip to content

oiiotool: better handling of wildcards that match no files #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgritz merged 1 commit into from
Feb 6, 2025
Merged

oiiotool: better handling of wildcards that match no files #4627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/oiiotool/oiiotool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7329,6 +7329,12 @@ handle_sequence(Oiiotool& ot, int argc, const char** argv)
nfilenames = frame_numbers[0].size();
}

if (!nfilenames) {
// No filenames matched the first wildcard pattern
ot.warning("", "No frame number or views matched the wildcards");
return false;
}

// Make sure frame_numbers[0] has the canonical frame number list
if (sequence_args.size() && frame_numbers[0].empty())
frame_numbers[0] = frame_numbers[sequence_args[0]];
Expand Down
5 changes: 4 additions & 1 deletion testsuite/oiiotool-control/ref/out.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,10 @@ Sequence -5--2: -5
Sequence -5--2: -4
Sequence -5--2: -3
Sequence -5--2: -2
oiiotool WARNING : oiiotool produced no output. Did you forget -o?
oiiotool WARNING : No frame number or views matched the wildcards
oiiotool ERROR: read : File does not exist: "notfound.#.jpg"
Full command line was:
> oiiotool notfound.#.jpg -o alsonotfound.#.jpg
oiiotool ERROR : Not all sequence specifications matched: copyA.#.jpg (10 frames) vs. copyC.1-5#.jpg (5 frames)
Full command line was:
>
Expand Down
Loading