oiiotool: better handling of wildcards that match no files #4627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use frame or view wildcards, for example:
oiiotool foo.%04d.tif -o bar.%04d.exr
we noticed that if NO files matched, no iteration would occur.
You would get this output:
```
$ oiiotool foo.%04d.tif -o bar.%04d.exr
oiiotool WARNING : oiiotool produced no output. Did you forget -o?
```
But maybe this is not helpful and it should be some kind of error
to ask for a match and not get one? Or at least give a more clear
explanation of what happened.
This PR detects the case where there is no match of the wildcard
at all, warns about that, and then tries interpreting the command
line literally (no wildcard expansion). So now the output is
```
$ oiiotool foo.%04d.tif -o bar.%04d.exr
oiiotool WARNING : No frame number or views matched the wildcards
oiiotool ERROR: read : File does not exist: "foo.%04d.tif"
Full command line was:
> oiiotool foo.%04d.tif -o bar.%04d.exr
```
Closes 4623
Signed-off-by: Larry Gritz <[email protected]>
grdanny
approved these changes
Feb 6, 2025
Contributor
grdanny
left a comment
grdanny
left a comment
There was a problem hiding this comment.
that's a nice change, thank you for that!
lgritz
added
enhancement
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 7, 2025
…ftwareFoundation#4627) When you use frame or view wildcards, for example: oiiotool foo.%04d.tif -o bar.%04d.exr we noticed that if NO files matched, no iteration would occur. You would get this output: ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : oiiotool produced no output. Did you forget -o? ``` But maybe this is not helpful and it should be some kind of error to ask for a match and not get one? Or at least give a more clear explanation of what happened. This PR detects the case where there is no match of the wildcard at all, warns about that, and then tries interpreting the command line literally (no wildcard expansion). So now the output is ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : No frame number or views matched the wildcards oiiotool ERROR: read : File does not exist: "foo.%04d.tif" Full command line was: > oiiotool foo.%04d.tif -o bar.%04d.exr ``` Closes AcademySoftwareFoundation#4623 Signed-off-by: Larry Gritz <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 17, 2025
…ftwareFoundation#4627) When you use frame or view wildcards, for example: oiiotool foo.%04d.tif -o bar.%04d.exr we noticed that if NO files matched, no iteration would occur. You would get this output: ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : oiiotool produced no output. Did you forget -o? ``` But maybe this is not helpful and it should be some kind of error to ask for a match and not get one? Or at least give a more clear explanation of what happened. This PR detects the case where there is no match of the wildcard at all, warns about that, and then tries interpreting the command line literally (no wildcard expansion). So now the output is ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : No frame number or views matched the wildcards oiiotool ERROR: read : File does not exist: "foo.%04d.tif" Full command line was: > oiiotool foo.%04d.tif -o bar.%04d.exr ``` Closes AcademySoftwareFoundation#4623 Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
scott-wilson
pushed a commit
to scott-wilson/OpenImageIO
that referenced
this pull request
May 18, 2025
…ftwareFoundation#4627) When you use frame or view wildcards, for example: oiiotool foo.%04d.tif -o bar.%04d.exr we noticed that if NO files matched, no iteration would occur. You would get this output: ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : oiiotool produced no output. Did you forget -o? ``` But maybe this is not helpful and it should be some kind of error to ask for a match and not get one? Or at least give a more clear explanation of what happened. This PR detects the case where there is no match of the wildcard at all, warns about that, and then tries interpreting the command line literally (no wildcard expansion). So now the output is ``` $ oiiotool foo.%04d.tif -o bar.%04d.exr oiiotool WARNING : No frame number or views matched the wildcards oiiotool ERROR: read : File does not exist: "foo.%04d.tif" Full command line was: > oiiotool foo.%04d.tif -o bar.%04d.exr ``` Closes AcademySoftwareFoundation#4623 Signed-off-by: Larry Gritz <[email protected]> Signed-off-by: Scott Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use frame or view wildcards, for example:
we noticed that if NO files matched, no iteration would occur. You would get this output:
But maybe this is not helpful and it should be some kind of error to ask for a match and not get one? Or at least give a more clear explanation of what happened.
This PR detects the case where there is no match of the wildcard at all, warns about that, and then tries interpreting the command line literally (no wildcard expansion). So now the output is
Closes #4623