This repository was archived by the owner on May 6, 2021. It is now read-only.
Platform: Fix platform init function of Musca S1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit
0eb7c91 HAL: Rename platform init function
combined `tfm_spm_hal_post_init` and `tfm_spm_hal_post_init_platform`
into a single weak function `tfm_hal_platform_init` which platforms
can override. But Musca S1 was missed out from the refactoring,
leading to issues such as IRQ and timers performances.
This commit completes the platform init refactoring for Musca S1 to
resolve the issues.
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Mar 8, 2021
This brings in the platform init fix: ARMmbed/trusted-firmware-m#15
evedon
approved these changes
Mar 9, 2021
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Mar 9, 2021
This brings in the platform init fix: ARMmbed/trusted-firmware-m#15
gpsimenos
pushed a commit
to ARMmbed/mbed-os
that referenced
this pull request
Mar 11, 2021
This brings in the platform init fix: ARMmbed/trusted-firmware-m#15
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit
combined
tfm_spm_hal_post_initandtfm_spm_hal_post_init_platforminto a single weak functiontfm_hal_platform_initwhich platforms can override. But Musca S1 was missed out from the refactoring, leading to issues such as IRQ and timers performances.This commit completes the platform init refactoring for Musca S1 to resolve the issues. The fix is the same as what the original commit did for the other targets.
@evedon Please review.