Update secure binaries with platform init fix for ARM_MUSCA_S1 #14391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDong-Arm
changed the title
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
0xc0170
previously approved these changes
Mar 8, 2021
|
cI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
We have a CI issue today. We can wait for ARMmbed/trusted-firmware-m#15 to get in first, after which I'll need to update VERSION.txt in this PR anyway. |
evedon
previously approved these changes
Mar 9, 2021
This brings in the platform init fix: ARMmbed/trusted-firmware-m#15
LDong-Arm
force-pushed
the
musca_s1_tfm_s
branch
from
934d389 to
31cc82d
Compare
mergify
bot
dismissed stale reviews from 0xc0170 and evedon
Pull request has been modified.
|
Rebased and added VERSION.txt |
evedon
approved these changes
Mar 9, 2021
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Due to a bug in TF-M v1.2, Musca S1 is not fully initialised by the secure binary. This leads to malfunctioning and performance issues around timer, IRQ, sleep, etc. Thanks to our Greentea test suites, we've caught this in our nightly CI - the failing suites are:
The fix is ARMmbed/trusted-firmware-m#15 which will also be upstreamed to the trusted-firmware-m project. This PR brings in the secure binaries containing the fix.
Impact of changes
Timings, IRQ and sleep related issues on Musca S1 are now fixed. All Greentea tests pass.
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers
@evedon