Prefer QSPI Bus mode 1-4-4 as highest priority for QSPIFBlockDevice #9057
Conversation
|
@dannybenor , @jeromecoutant, @cmonr - I've switched QSPIFBlockDevice to favor 1-4-4 mode on QPI. This will have negligible impact on performance on boards that do support QPI , and will enable the use of DISCO_F769NI board, once the required adjustments for it to support QSPI hal tests are made. |
|
@offirko, thank you for your changes. |
|
@offirko Would you mind mentioning a subset of #9057 (comment) in the commit comment? ( |
QPI may have slightly better performance, but it is not supported by all targets. It requires register setup between each Read and Program/Erase commands, which might damage the overall performance eventually.
offirko
force-pushed
the
offir_qspif_prefer_144_mode
branch
from
cf5ac83 to
b79c64e
Compare
|
@cmonr - I've updated the commit comment. I still didn't mention DISCO_F769NI in the comment because its a generic change that effects all targets - I hope its ok. |
|
@ARMmbed/mbed-os-storage Is this change acceptable? |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Prefer QSPI Bus mode 1-4-4 as highest priority for QSPIFBlockDevice.
QPI is not supported by all targets and requires register setup between each Read and Program/Erase commands, which might make the negligible advantage in sending the initial instruction become a disadvantage overall.
see issue: #8870
#8870 (comment)
Pull request type