-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix SWI conflict in SoftDevice for NRF52 series #7453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All SWI channels except SWI0 is being used by the SoftDevice and not only SWI1.
This fixes conflicts with the SoftDevice.
At least one user confirmed that this fixes the issue /morph build |
Build : SUCCESSBuild number : 2555 Triggering tests/morph test |
This seems to address the issue I was seeing in #7219 (comment) so is a significant improvement. However, there still appears to be an issue with SPI. I'm still trying to pin this down but it appears that on one of the spi buses I am using, it's not possible to read data. |
Test : SUCCESSBuild number : 2312 |
Is this a new issue or do you have an open github issue for it? |
@marcuschangarm It's 'new' in the sense that I only discovered it after overcoming the initial problems and it doesn't currently have its own issue id. I don't think it was caused by this fix and may have been present on master for some time, I only mentioned it here in case some variation of this fix might be relevant to SPI as well. Probably best if I raise a separate ticket for it. |
I don't recall any direct dependencies between SPI and UART/BLE. |
/morph export-build |
Exporter Build : SUCCESSBuild number : 2205 |
@NeilMacMullen If there isn't already an issue open, please go ahead and open one. We can track problems better when they're in a GitHub issues instead of comments in PRs. Bringing this in since the PR appears to address its initial problem scope. |
Resolves #7440 |
Fix SWI conflict in SoftDevice for NRF52 series
Description
SWI channels reserved for the SoftDevice were incorrectly defined leading to conflicts in the serial implementation. New serial driver only uses one SWI channel instead of four.
Pull request type