LoRa SX1276 LoRaWAN Sleep Mode Low Power Fix #15180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
ciarmcom
requested review from
0xc0170,
jeromecoutant,
MarceloSalazar and
a team
|
@hallard, thank you for your changes. |
connectivity/drivers/lora/COMPONENT_SX1276/SX1276_LoRaRadio.cpp
Outdated
Show resolved
Hide resolved
jeromecoutant
approved these changes
Nov 29, 2021
for custom boards like RAK811
… destructed. Fixed by removing timeout event from event queue on close/destruction.
Fix the following issues in TF-M to avoid emergence in the future:
1. Enable initial stack not located in SRAM bank0
On reset, only SRAM bank0 is enabled. And SRAM bank1/2 will be enabled in immediately following SystemInit().
When initial stack is located in SRAM bank1/2, we will meet trouble because SystemInit() itself needs to use initial stack.
To conquer the dilemma, we add preceding code in front of original Systeminit(), which is responsible for enabling SRAM bank1/2 and guarantees no using initial stack.
2. Fix sector maps of internal/external (SDH) Flash are incompatible, caused by TF-M's MCUboot port.
This is done by adapting external (SDH) Flash sector size to internal Flash's.
3. Enlarge firmware upgrade scratch size. There are two advantages:
(1) Get around MCUboot limit which requires scratch size not smaller than image trailer size
(2) Improve wear leveling for the scratch area
|
looks like still not expert of rebase/squash I suggest applying Merge/Squash when merging instead it becomes worst if I try again |
author Charles <[email protected]> 1637881721 +0100 committer Charles <[email protected]> 1638183821 +0100 parent bfa4f12 author Charles <[email protected]> 1637881721 +0100 committer Charles <[email protected]> 1638183722 +0100 Fixe Low Power high consumption Check TCXO available added TCXO startup delay STM32L1: add support of MCU_STM32L151xB for custom boards like RAK811 Allow STM32F7 targets without Ethernet Support different STM32F7 flash configurations Support missing SPI6 on STM32F7 Add STM32F722ZE target DTLSSocket handshake timeout calls object functions even if object is destructed. Fixed by removing timeout event from event queue on close/destruction. B_U585I_IOT02A supports OSPI M2354: Fix potential issues in TF-M Fix the following issues in TF-M to avoid emergence in the future: 1. Enable initial stack not located in SRAM bank0 On reset, only SRAM bank0 is enabled. And SRAM bank1/2 will be enabled in immediately following SystemInit(). When initial stack is located in SRAM bank1/2, we will meet trouble because SystemInit() itself needs to use initial stack. To conquer the dilemma, we add preceding code in front of original Systeminit(), which is responsible for enabling SRAM bank1/2 and guarantees no using initial stack. 2. Fix sector maps of internal/external (SDH) Flash are incompatible, caused by TF-M's MCUboot port. This is done by adapting external (SDH) Flash sector size to internal Flash's. 3. Enlarge firmware upgrade scratch size. There are two advantages: (1) Get around MCUboot limit which requires scratch size not smaller than image trailer size (2) Improve wear leveling for the scratch area Update Mbed version block Fixe Low Power high consumption Fix CI added TCXO startup delay
hallard
force-pushed
the
LORA_SX1276_LP_Fix
branch
from
28d16a8 to
cf52184
Compare
|
Replaced by #15181 |
mergify
bot
removed
needs: review
component: connectivity
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix sx1276 #227
May be same patch could be applied to #14224 (sx1272 and sx126x) but I have nothing to test
Impact of changes
Management of TCXO is now working fine
return DIO mapping of sx1276 to low power state
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@0xc0170 , @jeromecoutant , @MarceloSalazar