Fix IAR assembler errors on except.S #13366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@matthew-macovsky-cypress, thank you for your changes. |
|
cc @jeromecoutant this is similar to what you were seeing |
0xc0170
previously requested changes
Jul 29, 2020
There was a problem hiding this comment.
@matthew-macovsky-cypress Changes look fine to me. Can you add the details to the commit message please? The copy of the description from here should be sufficient.
|
#13248 for reference, also fixing the issue but differently. |
Fixes two errors produced on except.S by the IAR assembler (as seen in issue ARMmbed#13200). The first: "'ALIGN' is illegal. Use directive ALIGNROM or ALIGNRAM (the first parameter is raised to the power of 2, the second is a 32-bit fill value)." Fixed by changing ALIGN to ALIGNROM 2 to align to a 4-byte boundary (mirroring what ALIGN does in the ARM except.S). The second (on THUMB): "Must be placed inside a section" Fixed by moving THUMB after the SECTION directive so that it affects that section.
matthew-macovsky-cypress
force-pushed
the
pr/iar-except-fix
branch
from
7da9dab to
b7c0e89
Compare
|
@0xc0170 Updated the commit message. |
0xc0170
approved these changes
Jul 30, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
mbedmain
added
release-version: 6.2.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
These changes resolve the IAR assembler errors seen in issue #13200.
By running the IAR assembler directly I was able to see the actual error messages.
The first:
To resolve this I replaced ALIGN with ALIGNROM 2, which aligns to a 4-byte boundary (mirroring what ALIGN does in the ARM except.S).
The second:
To resolve this I moved THUMB after the SECTION directive so that it affects that section.
Documentation
None
Pull request type
Test results