Skip to content

IAR: compilation issues fix #13248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

IAR: compilation issues fix #13248

wants to merge 1 commit into from

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #13200

Issue were introduced in #12824

@0xc0170
@kjbracey-arm

Impact of changes

IAR compilation is back

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
IAR: compilation issues fix
5c3fca5 
NB: issues intriduced in ARMmbed#12824
0xc0170
0xc0170 reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented earlier. there are 3 things fixed , are they connected? w need section specified, branching instead of falling into and also alignment removal?

@jeromecoutant
Copy link
Collaborator Author

I don't know. The 3 fixes are needed for compilation.

Other solution could be to revert IAR patch from #12824

@ciarmcom ciarmcom requested review from a team July 8, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from kjbracey July 9, 2020 07:58
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2020

@kjbracey-arm Please review

@adbridge adbridge added the release-type: patch Indentifies a PR as containing just a patch label Jul 17, 2020
kjbracey
kjbracey reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see this is reverting some changes made in that other PR, but I don't know why they need to be reverted. Can you put in some explanation - what errors are you getting?

platform/source/TARGET_CORTEX_M/TOOLCHAIN_IAR/except.S
@@ -58,7 +59,7 @@ BusFault_Handler
UsageFault_Handler
EXPORT UsageFault_Handler
MOVS R3,#FAULT_TYPE_USAGE_FAULT
; Fall into Fault_Handler
B Fault_Handler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? To make Fault_Handler 4-byte aligned? But it doesn't need to be.

platform/source/TARGET_CORTEX_M/TOOLCHAIN_IAR/except.S
@@ -36,6 +36,7 @@ FAULT_TYPE_BUS_FAULT EQU 0x30
FAULT_TYPE_USAGE_FAULT EQU 0x40

PRESERVE8
SECTION .rodata:DATA:NOROOT(2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this doing?

@kjbracey
Copy link
Contributor

Oh, I see there's a bit of description in the GitHub linked issue, but that's never sufficient - what matters is what goes into the commit message.

But you never answered the question there - are all these changes necessary? Have you selectively tried seeing which one clears that silent error?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 29, 2020

PR #13366 fixes the issue with details - the changes are different. I'll close this one.

@0xc0170 0xc0170 closed this Jul 29, 2020
@mergify mergify bot removed needs: review release-type: patch Indentifies a PR as containing just a patch labels Jul 29, 2020
@0xc0170 0xc0170 mentioned this pull request Jul 29, 2020
Merged
@jeromecoutant jeromecoutant deleted the PR_IAR_6_1 branch August 10, 2020 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@kjbracey kjbracey kjbracey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mbed-os-6.1 can't compile with IAR
5 participants
@jeromecoutant @ciarmcom @0xc0170 @kjbracey @adbridge