Skip to content

Move emac-drivers from features into connectivity directory #13357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2020
Merged

Move emac-drivers from features into connectivity directory #13357

merged 2 commits into from
Jul 28, 2020

Conversation

rajkan01
Copy link
Contributor

Summary of changes

Moved mbed-os/features/netsocket/emac-drivers to mbed-os/connectivity/drivers/emac

Impact of changes

None.

Migration actions required

None.

Documentation

To be updated

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Manual testing: (Build for K64F target with ARMC6 toolchain)

  • mbed-os-example-sockets
  • Build greentea tests: Full profile and Bare metal profile
  • Unit tests build and run

Reviewers

LDong-Arm
LDong-Arm suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may drop "targets" from the paths: connectivity/drivers/emac/targets/TARGET_* -> connectivity/drivers/emac/TARGET_*. The drivers directory is dedicated to target-specific drivers.

@rajkan01 rajkan01 force-pushed the emac_dir_restructure branch from def68e0 to 99ebc01 Compare July 27, 2020 16:53
LDong-Arm
LDong-Arm reviewed Jul 27, 2020
View reviewed changes
connectivity/drivers/emac/README.md Outdated
@@ -32,7 +32,7 @@ to control your device. This must be derived from class `EMAC`.
This API is used by a network stack (or test framework) to control your driver.

The EMAC-derived driver would normally be installed in
features/netsocket/emac-drivers, often in a `TARGET_XXX` directory.
connectivity/drivers/emac/targets, often in a `TARGET_XXX` directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
connectivity/drivers/emac/targets, often in a `TARGET_XXX` directory.
connectivity/drivers/emac, often in a `TARGET_XXX` directory.

@rajkan01 rajkan01 force-pushed the emac_dir_restructure branch from 99ebc01 to 80d7404 Compare July 27, 2020 16:58
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 27, 2020
@ciarmcom ciarmcom requested a review from a team July 27, 2020 17:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@rajkan01
Copy link
Contributor Author

We may drop "targets" from the paths: connectivity/drivers/emac/targets/TARGET_* -> connectivity/drivers/emac/TARGET_*. The drivers directory is dedicated to target-specific drivers.

@LDong-Arm I dropped targets and moved TARGET_* into emac directory as you suggested, please re-review

LDong-Arm
LDong-Arm approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry there's another small remark. Otherwise it looks good to me.

doxyfile_options Outdated
*/mbed-trace/* \
*/mbed-coap/* \
*/nanostack-libservice/* \
*/mbed-client-randlib/* \
*/nanostack/sal-stack-nanostack-eventloop/* \
*/ble/generic/* \
*/ble/pal/* \
*/components/802.15.4_RF/* \
*connectivity/drivers/802.15.4_RF/* \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*connectivity/drivers/802.15.4_RF/* \
*/connectivity/drivers/802.15.4_RF/* \

just for consistency...

@rajkan01 rajkan01 force-pushed the emac_dir_restructure branch from 80d7404 to 2add706 Compare July 27, 2020 17:04
@LDong-Arm
Copy link
Contributor

LGTM

@mbed-ci
Copy link

mbed-ci commented Jul 27, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit f7ffd63 into ARMmbed:master Jul 28, 2020
@mergify mergify bot removed the ready for merge label Jul 28, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rajkan01 @ciarmcom @LDong-Arm @mbed-ci @0xc0170 @mbedmain