Add reserved memory reporting #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
force-pushed
the
add-reserved-memory-reporting
branch
from
2a6a366 to
fd242d5
Compare
bridadan
reviewed
Jun 12, 2017
mbed_greentea/mbed_report_api.py
Outdated
| @@ -17,6 +17,8 @@ | |||
| Author: Przemyslaw Wirkus <[email protected]> | |||
| """ | |||
|
|
|||
| from mbed_test_api import TEST_RESULT_OK | |||
There was a problem hiding this comment.
Can you remove this line? This doesn't look needed.
mazimkhan
reviewed
Jun 15, 2017
| re_tc_thread_info = re.compile(r"^\[(\d+\.\d+)\][^\{]+\{\{(__thread_info);\"([A-Fa-f0-9\-xX]+)\",(\d+),(\d+)\}\}") | ||
| for line in output.splitlines(): | ||
| m = re_tc_max_heap_usage.search(line) | ||
| if m: | ||
| _, _, max_heap_usage = m.groups() | ||
| max_heap_usage = int(max_heap_usage) | ||
|
|
||
| m = re_tc_reserved_heap.search(line) | ||
| if m: | ||
| _, _, reserved_heap = m.groups() |
There was a problem hiding this comment.
Alternatively you could do m.group(2). But it is just a cosmetic comment. Don't worry about it.
There was a problem hiding this comment.
Ah good to know, I was just matching the existing code snippet (above)
|
To be honest even I don't know this side of Greentea. If you have tested it well than I am ok. |
|
@geky This needs a rebase |
|
no it doesn't :P |
|
Oh oops :) |
bridadan
suggested changes
Jun 20, 2017
mbed_greentea/mbed_test_api.py
Outdated
| max_thread['max_stack_usage_total'] = max_stack_usage_total | ||
| max_thread['reserved_stack_total'] = reserved_stack_total | ||
| max_thread['reserved_stack_total'] = reserved_stack_total |
There was a problem hiding this comment.
Looks like this got duplicated, mind removing it?
mbed_greentea/mbed_test_api.py
Outdated
| @@ -573,6 +585,7 @@ def get_thread_stack_info_summary(thread_stack_info): | |||
| 'max_stack_size': max_thread_info['stack_size'], | |||
| 'max_stack_usage': max_thread_info['max_stack'], | |||
| 'max_stack_usage_total': max_thread_info['max_stack_usage_total'] | |||
There was a problem hiding this comment.
This line is missing a comma at the end.
studavekar
force-pushed
the
add-reserved-memory-reporting
branch
from
453f060 to
1a3ad86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have no idea what I'm doing!
But we are looking to add the reporting of the reserved memory regions (heap and stack). This seemed to do it, but feel free to be critical of our approach.
Sidenote: we're also looking to add the full memory regions (total rom/ram on a device) but this info is currently not available.
dependent on #223, ARMmbed/mbed-os#4504
commit range: 2a6a366
cc @studavekar, @bridadan